From 06f1290703c368c5779f500c66bb7247e271ee2d Mon Sep 17 00:00:00 2001 From: Sergio Gonzalez Monroy Date: Wed, 3 May 2023 14:26:44 +0200 Subject: ip-neighbor: fix aged neighbor probe The order of the parameters when calling the ip_neighbor_probe_dst for an aged neighbor is wrong and given that it runs on the master thread, probes for IPv6 neighbors were never sent, leading to a certain neighbor strike out and death and its removal from the neighbor cache. Change-Id: Ic021bd0ece05bd2c1c6ab90eab0e2dc27cb10360 Type: fix Fixes: fd2417b2a42 Signed-off-by: Sergio Gonzalez Monroy --- src/vnet/ip-neighbor/ip_neighbor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vnet/ip-neighbor/ip_neighbor.c b/src/vnet/ip-neighbor/ip_neighbor.c index a177da97c39..8e997e4920e 100644 --- a/src/vnet/ip-neighbor/ip_neighbor.c +++ b/src/vnet/ip-neighbor/ip_neighbor.c @@ -1598,8 +1598,8 @@ ip_neighbour_age_out (index_t ipni, f64 now, f64 * wait) } else { - ip_neighbor_probe_dst (ip_neighbor_get_sw_if_index (ipn), af, - vlib_get_thread_index (), + ip_neighbor_probe_dst (ip_neighbor_get_sw_if_index (ipn), + vlib_get_thread_index (), af, &ip_addr_46 (&ipn->ipn_key->ipnk_ip)); ipn->ipn_n_probes++; -- cgit 1.2.3-korg