From a7ec31750ca3d240adc3f6b3d9d189885b02d6df Mon Sep 17 00:00:00 2001 From: Steven Luong Date: Fri, 14 May 2021 15:33:01 -0700 Subject: lacp: coverity fix on null pointer dereference Coverity complains on null pointer dereference. It is not likely to happen. Type: fix Signed-off-by: Steven Luong Change-Id: Iab726a1e2d60725cec7ab0bbd2787b62e6393d33 --- src/plugins/lacp/selection.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/lacp/selection.c b/src/plugins/lacp/selection.c index 0c9f036308d..1588ebfd2eb 100644 --- a/src/plugins/lacp/selection.c +++ b/src/plugins/lacp/selection.c @@ -40,8 +40,8 @@ lacp_set_port_selected (vlib_main_t *vm, bond_if_t *bif, member_if_t *mif) { p = *vec_elt_at_index (bif->active_members, 0); mif2 = bond_get_member_by_sw_if_index (p); - if ((mif2->partner.key != mif->partner.key) || - memcmp (mif2->partner.system, mif->partner.system, 6)) + if (mif2 && ((mif2->partner.key != mif->partner.key) || + memcmp (mif2->partner.system, mif->partner.system, 6))) { mif->selected = LACP_PORT_UNSELECTED; lacp_machine_dispatch (&lacp_mux_machine, vm, mif, -- cgit 1.2.3-korg