aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOlivier Roques <oroques+fdio@cisco.com>2020-01-08 13:04:48 +0100
committerOlivier Roques <oroques+fdio@cisco.com>2020-01-08 13:04:48 +0100
commite0bc3a68a2dcf7fca2ae0a56a1cc628556b354bd (patch)
treef36d9d07c0a17bf4449e8218b725ccc4d98c3818
parentf5fe9c5b105feb2ba191a0af46d1633d0a2673d4 (diff)
[CICN-27] Fix invalid pointer dealloc
There is a deallocation of an invalid pointer in the destructor of an in-memory verifier object. This function is called by the destructor of consumer socket which fails because of that. The bug is visible only on Ubuntu 16.04. The bug was introduced in CICN-26 as an artifact of attempts to fix memory leaks in Android. There is no good reason to keep the changes causing the problem and the concerned lines can be safely removed. Signed-off-by: Olivier Roques <oroques+fdio@cisco.com> Change-Id: Ibcde7dd7510d76f5aa91e5967a4261ec7eb49108
-rw-r--r--libparc/parc/security/parc_InMemoryVerifier.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/libparc/parc/security/parc_InMemoryVerifier.c b/libparc/parc/security/parc_InMemoryVerifier.c
index 00dddf46..b713abce 100644
--- a/libparc/parc/security/parc_InMemoryVerifier.c
+++ b/libparc/parc/security/parc_InMemoryVerifier.c
@@ -51,8 +51,6 @@ _parcInMemoryVerifier_Destructor(PARCInMemoryVerifier **verifierPtr)
parcCryptoHasher_Release(&(verifier->hasher_sha256));
parcCryptoHasher_Release(&(verifier->hasher_sha512));
parcCryptoCache_Destroy(&(verifier->key_cache));
- parcMemory_Deallocate((void **)verifierPtr);
- *verifierPtr = NULL;
return true;
}