From e395c9b820525fca7f0f9fe7163b8dfb4b41c70e Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Tue, 28 May 2024 15:50:02 +0200 Subject: fix(hoststack): Do not limit number of RX queues This makes most scale hoststack tests correctly use both sibling cores. - Except quic multi-client ones, which start failing instead. - To be fixed later. - VPP startup.conf looks correct to me. - All quic tests suffer from CSIT-1935 so no big loss. Change-Id: If22c01651140865e188733039890f1fb0ceaa57a Signed-off-by: Vratko Polak (cherry picked from commit e417ac6f71f32064075d7f270c71f18f4cbe6f69) --- resources/libraries/robot/hoststack/hoststack.robot | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/resources/libraries/robot/hoststack/hoststack.robot b/resources/libraries/robot/hoststack/hoststack.robot index 20c071dc2d..dad1e59917 100644 --- a/resources/libraries/robot/hoststack/hoststack.robot +++ b/resources/libraries/robot/hoststack/hoststack.robot @@ -31,7 +31,6 @@ | ${quic_crypto_engine}= | nocrypto | ${quic_fifo_size}= | 4M | &{vpp_hoststack_attr}= -| ... | rxq=${1} | ... | rxd=${256} | ... | txd=${256} | ... | phy_cores=${1} @@ -140,7 +139,6 @@ | | ... | Set the VPP HostStack attributes in the vpp_hoststack_attr dictionary. | | | | ... | *Arguments:* -| | ... | - ${rxq} - Number of Rx Queues Type: int | | ... | - ${rxd} - Number of Rx Descriptors Type: int | | ... | - ${txd} - Number of Tx Descriptors Type: int | | ... | - ${phy_cores} - Number of cores for workers Type: int @@ -168,7 +166,6 @@ | | ... | \| Set VPP Hoststack Attributes \| phy_cores=${phy_cores} \| | | | | [Arguments] -| | ... | ${rxq}=${vpp_hoststack_attr}[rxq] | | ... | ${rxd}=${vpp_hoststack_attr}[rxd] | | ... | ${txd}=${vpp_hoststack_attr}[txd] | | ... | ${phy_cores}=${vpp_hoststack_attr}[phy_cores] @@ -183,7 +180,6 @@ | | ... | ${sess_lendpt_buckets}=${vpp_hoststack_attr}[sess_lendpt_buckets] | | ... | ${sess_lendpt_mem}=${vpp_hoststack_attr}[sess_lendpt_mem] | | -| | Set To Dictionary | ${vpp_hoststack_attr} | rxq | ${rxq} | | Set To Dictionary | ${vpp_hoststack_attr} | rxd | ${rxd} | | Set To Dictionary | ${vpp_hoststack_attr} | txd | ${txd} | | Set To Dictionary | ${vpp_hoststack_attr} | phy_cores | ${phy_cores} @@ -453,8 +449,8 @@ | | | | Set Max Rate And Jumbo | | Add worker threads to all DUTs -| | ... | ${vpp_hoststack_attr}[phy_cores] | ${vpp_hoststack_attr}[rxq] -| | ... | ${vpp_hoststack_attr}[rxd] | ${vpp_hoststack_attr}[txd] +| | ... | ${vpp_hoststack_attr}[phy_cores] +| | ... | rxd=${vpp_hoststack_attr}[rxd] | txd=${vpp_hoststack_attr}[txd] | | Pre-initialize layer driver | ${nic_driver} | | FOR | ${dut} | IN | @{duts} | | | Import Library | resources.libraries.python.VppConfigGenerator -- cgit 1.2.3-korg