From a912d105f3a1d8fed0b4cf6b18e0ef7789be81bf Mon Sep 17 00:00:00 2001 From: selias Date: Fri, 30 Sep 2016 14:04:06 +0200 Subject: Fix pylint warnings in python libraries - no functional changes - fixes 80+ PEP-8 violations Change-Id: Icf414778ec40d5cb44364fa69a876f9a1870c3c7 Signed-off-by: selias --- resources/libraries/python/DUTSetup.py | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'resources/libraries/python/DUTSetup.py') diff --git a/resources/libraries/python/DUTSetup.py b/resources/libraries/python/DUTSetup.py index e2d183fe4e..e176dd704a 100644 --- a/resources/libraries/python/DUTSetup.py +++ b/resources/libraries/python/DUTSetup.py @@ -11,6 +11,8 @@ # See the License for the specific language governing permissions and # limitations under the License. +"""DUT setup library.""" + from robot.api import logger from resources.libraries.python.topology import NodeType @@ -20,6 +22,7 @@ from resources.libraries.python.VatExecutor import VatExecutor class DUTSetup(object): + """Contains methods for setting up DUTs.""" @staticmethod def start_vpp_service_on_all_duts(nodes): """Start up the VPP service on all nodes.""" @@ -29,7 +32,7 @@ class DUTSetup(object): ssh.connect(node) (ret_code, stdout, stderr) = \ ssh.exec_command_sudo('service vpp restart') - if 0 != int(ret_code): + if int(ret_code) != 0: logger.debug('stdout: {0}'.format(stdout)) logger.debug('stderr: {0}'.format(stderr)) raise Exception('DUT {0} failed to start VPP service'. @@ -74,6 +77,13 @@ class DUTSetup(object): @staticmethod def setup_dut(node): + """Run script over SSH to setup the DUT node. + + :param node: DUT node to set up. + :type node: dict + + :raises Exception: If the DUT setup fails. + """ ssh = SSH() ssh.connect(node) @@ -82,7 +92,7 @@ class DUTSetup(object): Constants.REMOTE_FW_DIR, Constants.RESOURCES_LIB_SH)) logger.trace(stdout) logger.trace(stderr) - if 0 != int(ret_code): + if int(ret_code) != 0: logger.debug('DUT {0} setup script failed: "{1}"'. format(node['host'], stdout + stderr)) raise Exception('DUT test setup script failed at node {}'. -- cgit 1.2.3-korg