From 5e7be479eacd4d1085cab152c35dcb6433a146ed Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Thu, 26 Apr 2018 15:15:51 +0200 Subject: Fix various pylint 1.5.4 warnings + DUTSetup.py:424 Else clause on loop without a break statement + InterfaceUtil.py:400 Else clause on loop without a break statement + QemuUtils.py:564 Wrong continued indentation + SetupDPDKTest.py: Locally enabling broad-except + VatExecutor.py: Catching too general exception Exception + ssh.py:95 No exception type(s) specified. + HTTPRequest.py: Tolerate HTTPCodes.OK + multiple: Drop ":returns: None" from docstrings. There are still several warnings present: - R0902(too-many-instance-attributes) - R0912(too-many-branches) - R0913(too-many-arguments) - R0914(too-many-locals) - R0915(too-many-statements) - R0401(cyclic-import) And there are multiple blocks of similar lines, mainly across various Setup*Test.py files: - R0801(duplicate-code) Change-Id: I582575cb52b85d69d268e6374852f6e74bb71052 Signed-off-by: Vratko Polak --- resources/libraries/python/SFC/SFCTest.py | 1 - resources/libraries/python/SFC/VerifyPacket.py | 3 --- 2 files changed, 4 deletions(-) (limited to 'resources/libraries/python/SFC') diff --git a/resources/libraries/python/SFC/SFCTest.py b/resources/libraries/python/SFC/SFCTest.py index 2584632af9..d4f77baa52 100644 --- a/resources/libraries/python/SFC/SFCTest.py +++ b/resources/libraries/python/SFC/SFCTest.py @@ -43,7 +43,6 @@ class SFCTest(object): :type if1_adj_mac: str :type if2_adj_mac: str :type testtype: str - :returns: none :raises RuntimeError: If the script execute fails. """ diff --git a/resources/libraries/python/SFC/VerifyPacket.py b/resources/libraries/python/SFC/VerifyPacket.py index 90dfd375ca..a13c7601d5 100644 --- a/resources/libraries/python/SFC/VerifyPacket.py +++ b/resources/libraries/python/SFC/VerifyPacket.py @@ -66,7 +66,6 @@ class VerifyPacket(object): :param payload_data: the payload data in the packet. :type payload_data: str - :returns: none :raises RuntimeError: If the vxlan protocol field verify fails. """ # get the vxlan packet and check it @@ -87,7 +86,6 @@ class VerifyPacket(object): :param test_type: the functional test type. :type payload_data: str :type test_type: str - :returns: none :raises RuntimeError: If the vxlangpe and nsh protocol field verify fails. """ @@ -171,7 +169,6 @@ class VerifyPacket(object): :type ether: scapy.Ether :type frame_size: Integer :type test_type: str - :returns: none :raises RuntimeError: If the packet field verify fails. """ -- cgit 1.2.3-korg