From 063abf35e81deaf749ebbcfee339fbd1d9e89412 Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Wed, 4 Dec 2019 13:24:07 +0100 Subject: Deal with some "pylint: disable=" comments + When possible, fix the violation. + Else, add a comment: + An explanation (if not already present) and keep disable. + A TODO (if not already present) and remove the disable. - This makes tox job report more pylint violations, but any such violation is fixable and should be fixed. - Although some need to be fixed in VPP, such as enum item long names. Change-Id: I48604b5eda070083d79dff1439620dbd9e798e1f Signed-off-by: Vratko Polak --- resources/libraries/python/topology.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'resources/libraries/python/topology.py') diff --git a/resources/libraries/python/topology.py b/resources/libraries/python/topology.py index 46a6628a0a..92ade4a7a3 100644 --- a/resources/libraries/python/topology.py +++ b/resources/libraries/python/topology.py @@ -41,15 +41,19 @@ def load_topo_from_yaml(): return safe_load(work_file.read())[u"nodes"] -# pylint: disable=invalid-name class NodeType: """Defines node types used in topology dictionaries.""" + # TODO: Two letter initialisms are well-known, but too short for pylint. + # Candidates: TG -> TGN, VM -> VNF. + # Device Under Test (this node has VPP running on it) DUT = u"DUT" # Traffic Generator (this node has traffic generator on it) + # pylint: disable=invalid-name TG = u"TG" # Virtual Machine (this node running on DUT node) + # pylint: disable=invalid-name VM = u"VM" -- cgit 1.2.3-korg