From 4640b7da58f69f5b5aac69698656ae334735080c Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Fri, 12 Aug 2022 16:25:50 +0200 Subject: fix(robot): replace Run Keyword Unless Use Run Keyword If, with the condition negated. This silences the deprecation warning seen since Robot version bump. Change-Id: I9a88ff551994df3e129d71327f08207133a958a6 Signed-off-by: Vratko Polak --- resources/libraries/robot/l2/l2_bridge_domain.robot | 6 +++--- resources/libraries/robot/l2/l2_xconnect.robot | 4 ++-- resources/libraries/robot/l2/tagging.robot | 16 ++++++++-------- 3 files changed, 13 insertions(+), 13 deletions(-) (limited to 'resources/libraries/robot/l2') diff --git a/resources/libraries/robot/l2/l2_bridge_domain.robot b/resources/libraries/robot/l2/l2_bridge_domain.robot index f54d1685c4..dbf26d3f84 100644 --- a/resources/libraries/robot/l2/l2_bridge_domain.robot +++ b/resources/libraries/robot/l2/l2_bridge_domain.robot @@ -1,5 +1,5 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. -# Copyright (c) 2021 PANTHEON.tech and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. +# Copyright (c) 2022 PANTHEON.tech and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -495,7 +495,7 @@ | | VPP Set interface MTU | ${dut1} | ${dut1_eth_bond_if1} | | FOR | ${pf} | IN RANGE | 1 | ${nic_pfs} + 1 | | | ${_even}= | Evaluate | ${pf} % 2 -| | | Run Keyword Unless | ${even} +| | | Run Keyword If | not ${even} | | | ... | VPP Add Bond Member | | | ... | ${dut1} | ${DUT1_${int}${pf}}[0] | ${dut1_eth_bond_if1} | | END diff --git a/resources/libraries/robot/l2/l2_xconnect.robot b/resources/libraries/robot/l2/l2_xconnect.robot index 59199b6c90..1d4d40db3d 100644 --- a/resources/libraries/robot/l2/l2_xconnect.robot +++ b/resources/libraries/robot/l2/l2_xconnect.robot @@ -1,4 +1,4 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -247,7 +247,7 @@ | | VPP Set interface MTU | ${dut1} | ${dut1_eth_bond_if1} | | FOR | ${pf} | IN RANGE | 1 | ${nic_pfs} + 1 | | | ${_even}= | Evaluate | ${pf} % 2 -| | | Run Keyword Unless | ${even} +| | | Run Keyword If | not ${even} | | | ... | VPP Add Bond Member | | | ... | ${dut1} | ${DUT1_${int}${pf}}[0] | ${dut1_eth_bond_if1} | | END diff --git a/resources/libraries/robot/l2/tagging.robot b/resources/libraries/robot/l2/tagging.robot index dd4642c505..843b25d958 100644 --- a/resources/libraries/robot/l2/tagging.robot +++ b/resources/libraries/robot/l2/tagging.robot @@ -1,4 +1,4 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -82,24 +82,24 @@ | | ... | \| ${dut1_if2} \| 10 \| | | | | Set Interface State | ${DUT1} | ${INT1} | up -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | Set Interface State | ${DUT2} | ${INT2} | up | | ${INT1_NAME}= | Get interface name | ${DUT1} | ${INT1} -| | ${INT2_NAME}= | Run Keyword Unless | ${DUT2} == ${None} +| | ${INT2_NAME}= | Run Keyword If | ${DUT2} != ${None} | | ... | Get interface name | ${DUT2} | ${INT2} | | ${subif_name_1} | ${subif_index_1}= | Create Vlan Subinterface | | ... | ${DUT1} | ${INT1_NAME} | ${SUB_ID} | | ${subif_name_2} | ${subif_index_2}= -| | ... | Run Keyword Unless | ${DUT2} == ${None} +| | ... | Run Keyword If | ${DUT2} != ${None} | | ... | Create Vlan Subinterface | ${DUT2} | ${INT2_NAME} | ${SUB_ID} | | Set Interface State | ${DUT1} | ${subif_index_1} | up -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | Set Interface State | ${DUT2} | ${subif_index_2} | up | | Set Test Variable | ${subif_name_1} | | Set Test Variable | ${subif_index_1} -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | Set Test Variable | ${subif_name_2} -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | Set Test Variable | ${subif_index_2} | Configure L2 tag rewrite method on interfaces @@ -115,7 +115,7 @@ | | ... | - TAG_REWRITE_METHOD - Method of tag rewrite. | | | | L2 Vlan tag rewrite | ${DUT1} | ${SUB_INT1} | ${TAG_REWRITE_METHOD} -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | L2 Vlan tag rewrite | ${DUT2} | ${SUB_INT2} | ${TAG_REWRITE_METHOD} | Configure L2 tag rewrite method on interface -- cgit 1.2.3-korg