From 258f2666143138f20d84665fcfed53475bc88041 Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Tue, 16 Apr 2019 16:32:59 +0200 Subject: Clean up traffic_profile vs osi_layer The two types were not well distinguished before. Error introduced in: https://gerrit.fd.io/r/#/c/17811/84/resources/libraries/robot/performance/performance_setup.robot@255 Error hotfixed in: https://gerrit.fd.io/r/#/c/18847/4/resources/libraries/robot/shared/default.robot@109 + Rename some arguments and improve method docstrings. Newly introduced argument name osi_layer should be dissimilar enough. Change-Id: Ie0f6f97dc010fc6477f09c54574970f1d15462e2 Signed-off-by: Vratko Polak --- resources/libraries/robot/shared/default.robot | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'resources/libraries/robot/shared/default.robot') diff --git a/resources/libraries/robot/shared/default.robot b/resources/libraries/robot/shared/default.robot index 42c4f28cdc..dd4fb63c3f 100644 --- a/resources/libraries/robot/shared/default.robot +++ b/resources/libraries/robot/shared/default.robot @@ -106,23 +106,21 @@ | | ... | *Arguments:* | | ... | - numvfs - Number of VFs to initialize, 0 - disable the VFs | | ... | (Optional). Type: integer, default value: ${1} -| | ... | - traffic_profile - A value affecting behavior, such as spoofing. +| | ... | - osi_layer - OSI Layer type to initialize TG with. | | ... | (Optional). Type: string, default value: L2 -| | ... | Note: This is NOT the usual traffic profile -| | ... | (which is python module name to initialize TG with). | | ... | | ... | *Example:* | | ... | | ... | \| Configure AVF device on all DUTs \| ${1} \| L2 \| | | ... -| | [Arguments] | ${numvfs}=${1} | ${traffic_profile}=L2 +| | [Arguments] | ${numvfs}=${1} | ${osi_layer}=L2 | | ... | | ${duts}= | Get Matches | ${nodes} | DUT* | | :FOR | ${dut} | IN | @{duts} | | | ${if1_avf_arr}= | Init AVF interface | ${nodes['${dut}']} | ${${dut}_if1} -| | | ... | numvfs=${numvfs} | traffic_type=${traffic_profile} +| | | ... | numvfs=${numvfs} | osi_layer=${osi_layer} | | | ${if2_avf_arr}= | Init AVF interface | ${nodes['${dut}']} | ${${dut}_if2} -| | | ... | numvfs=${numvfs} | traffic_type=${traffic_profile} +| | | ... | numvfs=${numvfs} | osi_layer=${osi_layer} # Currently only one AVF is supported. | | | Set Suite Variable | ${${dut}_if1_vf0} | ${if1_avf_arr[0]} | | | Set Suite Variable | ${${dut}_if2_vf0} | ${if2_avf_arr[0]} -- cgit 1.2.3-korg