From a2a0ab1cdec3567dcad46c2000337707777aa0ca Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Wed, 13 Jun 2018 13:04:01 +0200 Subject: CSIT-1110: Prepare for migrating the new detection + Do not declare BitCountingClassifier.classify() as class method. + Make BitCountingGroupList subclass of list. + Inherit from abstract classes whenever possible. + Drop unneeded imports. + Add module docstrings and class docstrings anywhere. + Add TODOs hinting at possible improvements. Change-Id: Iccfff5c0e7be0607d6cfa74314083fcfe5a4d7d9 Signed-off-by: Vratko Polak --- resources/tools/presentation/new/jumpavg/RunGroup.py | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'resources/tools/presentation/new/jumpavg/RunGroup.py') diff --git a/resources/tools/presentation/new/jumpavg/RunGroup.py b/resources/tools/presentation/new/jumpavg/RunGroup.py index 808e02b792..9de8ae8919 100644 --- a/resources/tools/presentation/new/jumpavg/RunGroup.py +++ b/resources/tools/presentation/new/jumpavg/RunGroup.py @@ -11,8 +11,16 @@ # See the License for the specific language governing permissions and # limitations under the License. +"""Module holding RunGroup class.""" + class RunGroup(object): + """Effectively a named touple of data and metadata. + + TODO: This feels like an abstract class. + Most uses assume restrictions on metadata type. + Can this be defined similarly to C++ templates? + """ def __init__(self, metadata, values): """Create the group from metadata and values. -- cgit 1.2.3-korg