From 5e7be479eacd4d1085cab152c35dcb6433a146ed Mon Sep 17 00:00:00 2001 From: Vratko Polak Date: Thu, 26 Apr 2018 15:15:51 +0200 Subject: Fix various pylint 1.5.4 warnings + DUTSetup.py:424 Else clause on loop without a break statement + InterfaceUtil.py:400 Else clause on loop without a break statement + QemuUtils.py:564 Wrong continued indentation + SetupDPDKTest.py: Locally enabling broad-except + VatExecutor.py: Catching too general exception Exception + ssh.py:95 No exception type(s) specified. + HTTPRequest.py: Tolerate HTTPCodes.OK + multiple: Drop ":returns: None" from docstrings. There are still several warnings present: - R0902(too-many-instance-attributes) - R0912(too-many-branches) - R0913(too-many-arguments) - R0914(too-many-locals) - R0915(too-many-statements) - R0401(cyclic-import) And there are multiple blocks of similar lines, mainly across various Setup*Test.py files: - R0801(duplicate-code) Change-Id: I582575cb52b85d69d268e6374852f6e74bb71052 Signed-off-by: Vratko Polak --- resources/tools/topology/update_topology.py | 2 -- 1 file changed, 2 deletions(-) (limited to 'resources/tools') diff --git a/resources/tools/topology/update_topology.py b/resources/tools/topology/update_topology.py index f60fdf1653..2e267639ef 100755 --- a/resources/tools/topology/update_topology.py +++ b/resources/tools/topology/update_topology.py @@ -79,7 +79,6 @@ def update_mac_addresses_for_node(node): :param node: Node from topology. :type node: dict - :return: None """ for port_name, port in node['interfaces'].items(): if 'driver' not in port: @@ -128,7 +127,6 @@ def update_nodes_mac_addresses(topology): :param topology: Topology information with nodes. :type topology: dict - :return: None """ for node in topology['nodes'].values(): update_mac_addresses_for_node(node) -- cgit 1.2.3-korg