From d1f24d37bd447b64e402298bb8eb2479681facf9 Mon Sep 17 00:00:00 2001
From: Ondrej Fabry <ofabry@cisco.com>
Date: Fri, 17 Jul 2020 10:36:28 +0200
Subject: Improve binapi generator

- simplified Size/Marshal/Unmarshal methods
- replace struc in unions with custom marshal/unmarshal
- fix imports in generated files
- fix mock adapter
- generate rpc service using low-level stream API (dumps generate control ping or stream msg..)
- move examples/binapi to binapi and generate all API for latest release
- add binapigen.Plugin for developing custom generator plugins
- optionally generate HTTP handlers (REST API) for RPC services
- add govpp program for browsing VPP API

Change-Id: I092e9ed2b0c17972b3476463c3d4b14dd76ed42b
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
---
 binapigen/validate.go | 67 ---------------------------------------------------
 1 file changed, 67 deletions(-)
 delete mode 100644 binapigen/validate.go

(limited to 'binapigen/validate.go')

diff --git a/binapigen/validate.go b/binapigen/validate.go
deleted file mode 100644
index a79e148..0000000
--- a/binapigen/validate.go
+++ /dev/null
@@ -1,67 +0,0 @@
-//  Copyright (c) 2020 Cisco and/or its affiliates.
-//
-//  Licensed under the Apache License, Version 2.0 (the "License");
-//  you may not use this file except in compliance with the License.
-//  You may obtain a copy of the License at:
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-//  Unless required by applicable law or agreed to in writing, software
-//  distributed under the License is distributed on an "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-//  See the License for the specific language governing permissions and
-//  limitations under the License.
-
-package binapigen
-
-import (
-	"strings"
-
-	"github.com/sirupsen/logrus"
-
-	"git.fd.io/govpp.git/binapigen/vppapi"
-)
-
-const (
-	serviceEventPrefix   = "want_"
-	serviceDumpSuffix    = "_dump"
-	serviceDetailsSuffix = "_details"
-	serviceReplySuffix   = "_reply"
-)
-
-func validateService(svc vppapi.Service) {
-	for _, rpc := range svc.RPCs {
-		validateRPC(rpc)
-	}
-}
-
-func validateRPC(rpc vppapi.RPC) {
-	if len(rpc.Events) > 0 {
-		// EVENT service
-		if !strings.HasPrefix(rpc.RequestMsg, serviceEventPrefix) {
-			logrus.Warnf("unusual EVENTS service: %+v\n"+
-				"- events service %q does not have %q prefix in request.",
-				rpc, rpc.Name, serviceEventPrefix)
-		}
-	} else if rpc.Stream {
-		// STREAM service
-		if !strings.HasSuffix(rpc.RequestMsg, serviceDumpSuffix) {
-			logrus.Warnf("unusual STREAM service: %+v\n"+
-				"- stream service %q does not have %q suffix in request.",
-				rpc, rpc.Name, serviceDumpSuffix)
-		}
-		if !strings.HasSuffix(rpc.ReplyMsg, serviceDetailsSuffix) && !strings.HasSuffix(rpc.StreamMsg, serviceDetailsSuffix) {
-			logrus.Warnf("unusual STREAM service: %+v\n"+
-				"- stream service %q does not have %q suffix in reply or stream msg.",
-				rpc, rpc.Name, serviceDetailsSuffix)
-		}
-	} else if rpc.ReplyMsg != "" {
-		// REQUEST service
-		// some messages might have `null` reply (for example: memclnt)
-		if !strings.HasSuffix(rpc.ReplyMsg, serviceReplySuffix) {
-			logrus.Warnf("unusual REQUEST service: %+v\n"+
-				"- service %q does not have %q suffix in reply.",
-				rpc, rpc.Name, serviceReplySuffix)
-		}
-	}
-}
-- 
cgit 1.2.3-korg