summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarek Gradzki <mgradzki@cisco.com>2017-11-22 11:32:17 +0100
committerMarek Gradzki <mgradzki@cisco.com>2017-11-22 12:37:08 +0000
commitf51020f3e23de8a15a98ab61da2a25c43b19a963 (patch)
tree1fcc3a6f967219ab8612cddba2887d357f81a336
parent16ca3ce180f51666631c980909289eb332cb87d4 (diff)
Add missing @Override annotations
Fix isses reported by Sonar thanks to IntelliJ's code inspection. Change-Id: I846590213e3e8ac7d3539d4de9940b32818625d5 Signed-off-by: Marek Gradzki <mgradzki@cisco.com> (cherry picked from commit b1f0c71b032eb17d8cac1c5324745b759c2da87f)
-rw-r--r--l3/impl/src/test/java/io/fd/hc2vpp/l3/write/ipv4/Ipv4AddressCustomizerTest.java1
-rw-r--r--lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java1
-rw-r--r--lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java1
-rw-r--r--lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java1
-rw-r--r--lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java1
-rw-r--r--lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java2
-rw-r--r--lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/write/ItrRemoteLocatorSetCustomizerTest.java1
-rw-r--r--v3po/v3po2vpp/src/test/java/io/fd/hc2vpp/v3po/interfaces/span/MirroredInterfacesCustomizerTest.java1
-rw-r--r--vpp-common/vpp-common-integration/src/main/java/io/fd/hc2vpp/common/integration/VppCommonModule.java1
9 files changed, 10 insertions, 0 deletions
diff --git a/l3/impl/src/test/java/io/fd/hc2vpp/l3/write/ipv4/Ipv4AddressCustomizerTest.java b/l3/impl/src/test/java/io/fd/hc2vpp/l3/write/ipv4/Ipv4AddressCustomizerTest.java
index 74745c485..850c1baeb 100644
--- a/l3/impl/src/test/java/io/fd/hc2vpp/l3/write/ipv4/Ipv4AddressCustomizerTest.java
+++ b/l3/impl/src/test/java/io/fd/hc2vpp/l3/write/ipv4/Ipv4AddressCustomizerTest.java
@@ -74,6 +74,7 @@ public class Ipv4AddressCustomizerTest extends WriterCustomizerTest {
return o -> o instanceof InstanceIdentifier && (o.getTargetType().equals(desiredClass));
}
+ @Override
@Before
public void setUpTest() throws Exception {
interfaceContext = new NamingContext("generatedIfaceName", IFC_CTX_NAME);
diff --git a/lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java b/lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java
index 17ecd402d..5312c2ea5 100644
--- a/lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java
+++ b/lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java
@@ -65,6 +65,7 @@ public final class LispStateCheckServiceImpl implements LispStateCheckService, J
.or(STATIC_LISP_INSTANCE).isEnable(), "Lisp feature not enabled");
}
+ @Override
public boolean lispEnabled(@Nonnull final ReadContext ctx) {
// in this case it must be dumped
try {
diff --git a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java
index 1d78d5cb5..295f75244 100644
--- a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java
+++ b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java
@@ -101,6 +101,7 @@ public class BridgeDomainSubtableCustomizerTest
fail("Test should throw ReadFailedException");
}
+ @Override
@Test
public void testGetBuilder() {
final BridgeDomainSubtableBuilder builder = customizer.getBuilder(validId);
diff --git a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java
index 5bc994a39..5c09d2706 100644
--- a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java
+++ b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java
@@ -56,6 +56,7 @@ public class ItrRemoteLocatorSetCustomizerTest
super(ItrRemoteLocatorSet.class, LispFeatureDataBuilder.class);
}
+ @Override
@Before
public void setUp() throws Exception {
validId = InstanceIdentifier.create(ItrRemoteLocatorSet.class);
diff --git a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java
index fc4344cf4..4012084b7 100644
--- a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java
+++ b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java
@@ -78,6 +78,7 @@ public class LocalMappingCustomizerTest extends
}
+ @Override
public void setUp() {
emptyIdentifier = InstanceIdentifier.create(EidTable.class)
.child(VniTable.class, new VniTableKey(12L))
diff --git a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java
index 9b7dadadf..ff3297ed6 100644
--- a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java
+++ b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java
@@ -100,6 +100,7 @@ public class VrfSubtableCustomizerTest extends SubtableReaderTestCase<VrfSubtabl
return new VrfSubtableCustomizer(api);
}
+ @Override
@Test
public void testGetBuilder() {
final VrfSubtableBuilder builder = customizer.getBuilder(validId);
@@ -110,6 +111,7 @@ public class VrfSubtableCustomizerTest extends SubtableReaderTestCase<VrfSubtabl
assertNull(builder.getTableId());
}
+ @Override
@Test
public void testMerge() {
VniTableBuilder parentBuilder = new VniTableBuilder();
diff --git a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/write/ItrRemoteLocatorSetCustomizerTest.java b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/write/ItrRemoteLocatorSetCustomizerTest.java
index 0ecf0e531..5140121a6 100644
--- a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/write/ItrRemoteLocatorSetCustomizerTest.java
+++ b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/write/ItrRemoteLocatorSetCustomizerTest.java
@@ -54,6 +54,7 @@ public class ItrRemoteLocatorSetCustomizerTest extends LispWriterCustomizerTest
private InstanceIdentifier<ItrRemoteLocatorSet> validId;
private ItrRemoteLocatorSet validData;
+ @Override
@Before
public void setUpTest() throws Exception {
initMocks(this);
diff --git a/v3po/v3po2vpp/src/test/java/io/fd/hc2vpp/v3po/interfaces/span/MirroredInterfacesCustomizerTest.java b/v3po/v3po2vpp/src/test/java/io/fd/hc2vpp/v3po/interfaces/span/MirroredInterfacesCustomizerTest.java
index edf31a608..4e6fdddcc 100644
--- a/v3po/v3po2vpp/src/test/java/io/fd/hc2vpp/v3po/interfaces/span/MirroredInterfacesCustomizerTest.java
+++ b/v3po/v3po2vpp/src/test/java/io/fd/hc2vpp/v3po/interfaces/span/MirroredInterfacesCustomizerTest.java
@@ -57,6 +57,7 @@ public class MirroredInterfacesCustomizerTest extends WriterCustomizerTest {
@Captor
private ArgumentCaptor<SwInterfaceSpanEnableDisable> requestCaptor;
+ @Override
public void setUpTest() {
interfaceContext = new NamingContext("iface", "iface-context");
customizer =
diff --git a/vpp-common/vpp-common-integration/src/main/java/io/fd/hc2vpp/common/integration/VppCommonModule.java b/vpp-common/vpp-common-integration/src/main/java/io/fd/hc2vpp/common/integration/VppCommonModule.java
index 7e6a0f7a4..e66a72327 100644
--- a/vpp-common/vpp-common-integration/src/main/java/io/fd/hc2vpp/common/integration/VppCommonModule.java
+++ b/vpp-common/vpp-common-integration/src/main/java/io/fd/hc2vpp/common/integration/VppCommonModule.java
@@ -26,6 +26,7 @@ import io.fd.vpp.jvpp.core.future.FutureJVppCore;
import net.jmob.guice.conf.core.ConfigurationModule;
public final class VppCommonModule extends AbstractModule {
+ @Override
protected void configure() {
install(ConfigurationModule.create());