From e62b49fe00bf71ea80cbbbf2037a6c2565f88edd Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Thu, 7 Sep 2017 13:06:55 +0200 Subject: Fix error-handling issues found by Sonar Change-Id: Ic370f72c16beaf56003021a6a89f751de8b744b8 Signed-off-by: Marek Gradzki (cherry picked from commit fc809432b5560bf36e7d5b14b998751ed0e9a229) --- .../io/fd/hc2vpp/vppioam/impl/config/IoamTraceWriterCustomizer.java | 4 ++-- .../main/java/io/fd/hc2vpp/common/translate/util/Ipv4Translator.java | 2 +- .../main/java/io/fd/hc2vpp/common/translate/util/Ipv6Translator.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ioam/impl/src/main/java/io/fd/hc2vpp/vppioam/impl/config/IoamTraceWriterCustomizer.java b/ioam/impl/src/main/java/io/fd/hc2vpp/vppioam/impl/config/IoamTraceWriterCustomizer.java index 2e260e108..af9e5dadd 100755 --- a/ioam/impl/src/main/java/io/fd/hc2vpp/vppioam/impl/config/IoamTraceWriterCustomizer.java +++ b/ioam/impl/src/main/java/io/fd/hc2vpp/vppioam/impl/config/IoamTraceWriterCustomizer.java @@ -93,7 +93,7 @@ public class IoamTraceWriterCustomizer extends FutureJVppIoamtraceCustomizer } public TraceProfileAddReply addTraceConfig(TraceConfig traceConfig, - final InstanceIdentifier id) throws Exception { + final InstanceIdentifier id) throws WriteFailedException { TraceProfileAdd traceProfileAdd = new TraceProfileAdd(); traceProfileAdd.traceType = traceConfig.getTraceType().byteValue(); //trace type @@ -110,7 +110,7 @@ public class IoamTraceWriterCustomizer extends FutureJVppIoamtraceCustomizer } public TraceProfileDelReply deleteTraceConfig(TraceConfig dataBefore, - final InstanceIdentifier id) throws Exception { + final InstanceIdentifier id) throws WriteFailedException { TraceProfileDel del = new TraceProfileDel(); /* Write to VPP */ diff --git a/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv4Translator.java b/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv4Translator.java index 02f89d9f8..69ef7f3ab 100644 --- a/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv4Translator.java +++ b/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv4Translator.java @@ -116,7 +116,7 @@ public interface Ipv4Translator extends ByteDataTranslator { String.valueOf(prefix))); } catch (UnknownHostException e) { throw new IllegalArgumentException( - "Cannot create prefix for address[" + Arrays.toString(address) + "],prefix[" + prefix + "]"); + "Cannot create prefix for address[" + Arrays.toString(address) + "],prefix[" + prefix + "]", e); } } } diff --git a/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv6Translator.java b/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv6Translator.java index 664bdc37d..d6e23e77d 100644 --- a/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv6Translator.java +++ b/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv6Translator.java @@ -131,7 +131,7 @@ public interface Ipv6Translator extends ByteDataTranslator { String.valueOf(prefix))); } catch (UnknownHostException e) { throw new IllegalArgumentException( - "Cannot create prefix for address[" + Arrays.toString(address) + "],prefix[" + prefix + "]"); + "Cannot create prefix for address[" + Arrays.toString(address) + "],prefix[" + prefix + "]", e); } } -- cgit 1.2.3-korg