From b1f0c71b032eb17d8cac1c5324745b759c2da87f Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Wed, 22 Nov 2017 11:32:17 +0100 Subject: Add missing @Override annotations Fix isses reported by Sonar thanks to IntelliJ's code inspection. Change-Id: I846590213e3e8ac7d3539d4de9940b32818625d5 Signed-off-by: Marek Gradzki --- .../io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java | 1 + .../hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java | 1 + .../hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java | 1 + .../io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java | 1 + .../io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java | 2 ++ .../hc2vpp/lisp/translate/write/ItrRemoteLocatorSetCustomizerTest.java | 1 + 6 files changed, 7 insertions(+) (limited to 'lisp') diff --git a/lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java b/lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java index 17ecd402d..5312c2ea5 100644 --- a/lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java +++ b/lisp/lisp2vpp/src/main/java/io/fd/hc2vpp/lisp/translate/service/LispStateCheckServiceImpl.java @@ -65,6 +65,7 @@ public final class LispStateCheckServiceImpl implements LispStateCheckService, J .or(STATIC_LISP_INSTANCE).isEnable(), "Lisp feature not enabled"); } + @Override public boolean lispEnabled(@Nonnull final ReadContext ctx) { // in this case it must be dumped try { diff --git a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java index 1d78d5cb5..295f75244 100644 --- a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java +++ b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/BridgeDomainSubtableCustomizerTest.java @@ -101,6 +101,7 @@ public class BridgeDomainSubtableCustomizerTest fail("Test should throw ReadFailedException"); } + @Override @Test public void testGetBuilder() { final BridgeDomainSubtableBuilder builder = customizer.getBuilder(validId); diff --git a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java index 5bc994a39..5c09d2706 100644 --- a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java +++ b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/ItrRemoteLocatorSetCustomizerTest.java @@ -56,6 +56,7 @@ public class ItrRemoteLocatorSetCustomizerTest super(ItrRemoteLocatorSet.class, LispFeatureDataBuilder.class); } + @Override @Before public void setUp() throws Exception { validId = InstanceIdentifier.create(ItrRemoteLocatorSet.class); diff --git a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java index fc4344cf4..4012084b7 100644 --- a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java +++ b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/LocalMappingCustomizerTest.java @@ -78,6 +78,7 @@ public class LocalMappingCustomizerTest extends } + @Override public void setUp() { emptyIdentifier = InstanceIdentifier.create(EidTable.class) .child(VniTable.class, new VniTableKey(12L)) diff --git a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java index 9b7dadadf..ff3297ed6 100644 --- a/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java +++ b/lisp/lisp2vpp/src/test/java/io/fd/hc2vpp/lisp/translate/read/VrfSubtableCustomizerTest.java @@ -100,6 +100,7 @@ public class VrfSubtableCustomizerTest extends SubtableReaderTestCase validId; private ItrRemoteLocatorSet validData; + @Override @Before public void setUpTest() throws Exception { initMocks(this); -- cgit 1.2.3-korg