From 928d0b286b586c76658449480291b9445a52b74b Mon Sep 17 00:00:00 2001
From: Maros Marsalek <mmarsale@cisco.com>
Date: Mon, 5 Sep 2016 12:10:26 +0200
Subject: Cleanup TODOs and FIXMEs

- Fix minor ones
- Report bigger and include issue number in comment
- Pull common dependencies into dependency management of common/parents

Change-Id: I06a6ac37c52b603fd73ed42023d6b2e7fa18010f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
---
 samples/interfaces/Readme.adoc     |  2 --
 samples/interfaces/mapping/pom.xml |  3 ---
 samples/interfaces/models/pom.xml  | 12 ------------
 3 files changed, 17 deletions(-)

(limited to 'samples')

diff --git a/samples/interfaces/Readme.adoc b/samples/interfaces/Readme.adoc
index 6d73df456..1ee409164 100644
--- a/samples/interfaces/Readme.adoc
+++ b/samples/interfaces/Readme.adoc
@@ -6,5 +6,3 @@ Only sample data are used, that are not actually handled
 
 == Notifications
 A sample notification was added to the models to showcase notification capabilities
-
-// TODO provide a groovy version, will be more compact
\ No newline at end of file
diff --git a/samples/interfaces/mapping/pom.xml b/samples/interfaces/mapping/pom.xml
index 49b0111a8..bd5eabfe6 100644
--- a/samples/interfaces/mapping/pom.xml
+++ b/samples/interfaces/mapping/pom.xml
@@ -41,17 +41,14 @@
     <dependency>
       <groupId>com.google.inject</groupId>
       <artifactId>guice</artifactId>
-      <version>${guice.version}</version>
     </dependency>
     <dependency>
       <groupId>net.jmob</groupId>
       <artifactId>guice.conf</artifactId>
-      <version>${guice.config.version}</version>
     </dependency>
     <dependency>
       <groupId>com.google.inject.extensions</groupId>
       <artifactId>guice-multibindings</artifactId>
-      <version>${guice.version}</version>
     </dependency>
 
     <dependency>
diff --git a/samples/interfaces/models/pom.xml b/samples/interfaces/models/pom.xml
index 3bb506032..712f82cfa 100644
--- a/samples/interfaces/models/pom.xml
+++ b/samples/interfaces/models/pom.xml
@@ -27,18 +27,6 @@
   <version>1.16.12-SNAPSHOT</version>
   <packaging>bundle</packaging>
 
-  <dependencyManagement>
-    <dependencies>
-      <dependency>
-        <groupId>org.opendaylight.mdsal.model</groupId>
-        <artifactId>mdsal-model-artifacts</artifactId>
-        <version>0.8.2-Beryllium-SR2</version>
-        <type>pom</type>
-        <scope>import</scope>
-      </dependency>
-    </dependencies>
-  </dependencyManagement>
-
   <dependencies>
     <!-- Uncomment if iana-if-type model is imported -->
     <!--<dependency>-->
-- 
cgit 1.2.3-korg