summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarek Gradzki <mgradzki@cisco.com>2016-05-16 15:02:42 +0200
committerMarek Gradzki <mgradzki@cisco.com>2016-05-19 11:24:40 +0000
commitfb462a4622ce1ba07fb6fce7f2d2aac846391ab2 (patch)
tree4f8c40aba0972d526cf8dccea30eeb416f0e92d4
parent4d9cfe0ec2a564a9eff63978ded0e0241b787903 (diff)
HONEYCOMB-48: sub-interface CRUD support
Change-Id: Id6ca6776ca988aef060ecc33c508b7b699c53d10 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
-rw-r--r--v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/SubInterfaceCustomizer.java153
-rw-r--r--v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtils.java5
-rw-r--r--v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/SubInterfaceCustomizer.java115
-rw-r--r--v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/SubInterfaceCustomizerTest.java189
-rw-r--r--v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtilsTest.java2
-rw-r--r--v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/SubInterfaceCustomizerTest.java102
6 files changed, 566 insertions, 0 deletions
diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/SubInterfaceCustomizer.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/SubInterfaceCustomizer.java
new file mode 100644
index 000000000..ecf2337e8
--- /dev/null
+++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/SubInterfaceCustomizer.java
@@ -0,0 +1,153 @@
+/*
+ * Copyright (c) 2016 Cisco and/or its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.fd.honeycomb.v3po.translate.v3po.interfaces;
+
+import static io.fd.honeycomb.v3po.translate.v3po.utils.V3poUtils.booleanToByte;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import io.fd.honeycomb.v3po.translate.v3po.util.AbstractInterfaceTypeCustomizer;
+import io.fd.honeycomb.v3po.translate.v3po.util.NamingContext;
+import io.fd.honeycomb.v3po.translate.v3po.util.VppApiInvocationException;
+import io.fd.honeycomb.v3po.translate.v3po.utils.V3poUtils;
+import io.fd.honeycomb.v3po.translate.write.WriteContext;
+import io.fd.honeycomb.v3po.translate.write.WriteFailedException;
+import java.util.concurrent.CompletionStage;
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.InterfaceType;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.Interface;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VlanTag;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VlanType;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VppInterfaceAugmentation;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.interfaces._interface.SubInterface;
+import org.opendaylight.yangtools.yang.binding.DataObject;
+import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
+import org.openvpp.jvpp.dto.CreateSubif;
+import org.openvpp.jvpp.dto.CreateSubifReply;
+import org.openvpp.jvpp.future.FutureJVpp;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Writer Customizer responsible for sub interface creation.<br>
+ * Sends {@code create_subif} message to VPP.<br>
+ * Equivalent of invoking {@code vppclt create subif} command.
+ */
+public class SubInterfaceCustomizer extends AbstractInterfaceTypeCustomizer<SubInterface> {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SubInterfaceCustomizer.class);
+ private final NamingContext interfaceContext;
+
+ public SubInterfaceCustomizer(@Nonnull final FutureJVpp futureJvpp, @Nonnull final NamingContext interfaceContext) {
+ super(futureJvpp);
+ this.interfaceContext = Preconditions.checkNotNull(interfaceContext, "interfaceContext should not be null");
+ }
+
+ @Nonnull
+ @Override
+ public Optional<SubInterface> extract(@Nonnull final InstanceIdentifier<SubInterface> currentId,
+ @Nonnull final DataObject parentData) {
+ return Optional.fromNullable(((VppInterfaceAugmentation) parentData).getSubInterface());
+ }
+
+ @Override
+ protected Class<? extends InterfaceType> getExpectedInterfaceType() {
+ return org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.SubInterface.class;
+ }
+
+ @Override
+ public void writeInterface(@Nonnull final InstanceIdentifier<SubInterface> id,
+ @Nonnull final SubInterface dataAfter, @Nonnull final WriteContext writeContext)
+ throws WriteFailedException.CreateFailedException {
+ try {
+ createSubInterface(id.firstKeyOf(Interface.class).getName(), dataAfter);
+ } catch (VppApiInvocationException e) {
+ throw new WriteFailedException.CreateFailedException(id, dataAfter, e);
+ }
+ }
+
+ private void createSubInterface(final String swIfName, final SubInterface subInterface) throws VppApiInvocationException {
+ final String superIfName = subInterface.getSuperInterface();
+ final int swIfIndex = interfaceContext.getIndex(superIfName);
+ LOG.debug("Creating sub interface of {}(id={}): name={}, subInterface={}", superIfName, swIfIndex, swIfName, subInterface);
+ final CompletionStage<CreateSubifReply> createSubifReplyCompletionStage =
+ getFutureJVpp().createSubif(getCreateSubifRequest(subInterface, swIfIndex));
+
+ final CreateSubifReply reply =
+ V3poUtils.getReply(createSubifReplyCompletionStage.toCompletableFuture());
+ if (reply.retval < 0) {
+ LOG.debug("Failed to create sub interface for: {}, subInterface: {}", swIfName, subInterface);
+ throw new VppApiInvocationException("createSubif", reply.context, reply.retval);
+ } else {
+ LOG.debug("Sub interface created successfully for: {}, subInterface: {}", swIfName, subInterface);
+ // Add new interface to our interface context
+ interfaceContext.addName(reply.swIfIndex, swIfName);
+ }
+ }
+
+ private CreateSubif getCreateSubifRequest(final SubInterface subInterface, final int swIfIndex) {
+ CreateSubif request = new CreateSubif();
+ request.subId = Math.toIntExact(subInterface.getIdentifier().intValue());
+ request.swIfIndex = swIfIndex;
+ switch (subInterface.getNumberOfTags()) {
+ case 0:
+ request.noTags = 1;
+ break;
+ case 1:
+ request.oneTag = 1;
+ break;
+ case 2:
+ request.twoTags = 1;
+ break;
+ }
+ request.dot1Ad = booleanToByte(VlanType._802dot1q.equals(subInterface.getVlanType()));
+ request.exactMatch = booleanToByte(subInterface.isExactMatch());
+ request.defaultSub = booleanToByte(subInterface.isDefaultSubif());
+ request.outerVlanIdAny = booleanToByte(subInterface.isMatchAnyInnerId());
+ request.innerVlanIdAny = booleanToByte(subInterface.isMatchAnyInnerId());
+ request.outerVlanId = vlanTagToChar(subInterface.getOuterId());
+ request.innerVlanId = vlanTagToChar(subInterface.getInnerId());
+ return request;
+ }
+
+ private static char vlanTagToChar(@Nullable VlanTag tag) {
+ if (tag == null) {
+ return 0; // tell VPP that optional argument is missing
+ } else {
+ return (char)tag.getValue().intValue();
+ }
+ }
+
+ @Override
+ public void updateCurrentAttributes(@Nonnull final InstanceIdentifier<SubInterface> id,
+ @Nonnull final SubInterface dataBefore, @Nonnull final SubInterface dataAfter,
+ @Nonnull final WriteContext writeContext) throws WriteFailedException.UpdateFailedException {
+ if (dataBefore.equals(dataAfter)) {
+ LOG.debug("dataBefore equals dataAfter, update will not be performed");
+ return;
+ }
+ throw new UnsupportedOperationException("Sub interface update is not supported");
+ }
+
+ @Override
+ public void deleteCurrentAttributes(@Nonnull final InstanceIdentifier<SubInterface> id,
+ @Nonnull final SubInterface dataBefore, @Nonnull final WriteContext writeContext)
+ throws WriteFailedException.DeleteFailedException {
+ throw new UnsupportedOperationException("Sub interface delete is not supported");
+ }
+}
diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtils.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtils.java
index 1ee472745..a6c887336 100644
--- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtils.java
+++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtils.java
@@ -33,6 +33,7 @@ import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.iana._if.type.re
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.InterfaceType;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state.InterfaceKey;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Gauge64;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.SubInterface;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.Tap;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VhostUser;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VxlanTunnel;
@@ -217,6 +218,10 @@ public final class InterfaceUtils {
return VhostUser.class;
}
+ if (interfaceName.contains(".")) {
+ return SubInterface.class;
+ }
+
return EthernetCsmacd.class;
}
diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/SubInterfaceCustomizer.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/SubInterfaceCustomizer.java
new file mode 100644
index 000000000..b68acbfa3
--- /dev/null
+++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/SubInterfaceCustomizer.java
@@ -0,0 +1,115 @@
+/*
+ * Copyright (c) 2016 Cisco and/or its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.fd.honeycomb.v3po.translate.v3po.interfacesstate;
+
+import static io.fd.honeycomb.v3po.translate.v3po.interfacesstate.InterfaceUtils.isInterfaceOfType;
+
+import com.google.common.base.Preconditions;
+import io.fd.honeycomb.v3po.translate.Context;
+import io.fd.honeycomb.v3po.translate.read.ReadFailedException;
+import io.fd.honeycomb.v3po.translate.spi.read.ChildReaderCustomizer;
+import io.fd.honeycomb.v3po.translate.v3po.util.FutureJVppCustomizer;
+import io.fd.honeycomb.v3po.translate.v3po.util.NamingContext;
+import javax.annotation.Nonnull;
+import org.apache.commons.lang3.builder.ReflectionToStringBuilder;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state.Interface;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state.InterfaceKey;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VlanTag;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VlanType;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VppInterfaceStateAugmentationBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.interfaces.state._interface.SubInterface;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.interfaces.state._interface.SubInterfaceBuilder;
+import org.opendaylight.yangtools.concepts.Builder;
+import org.opendaylight.yangtools.yang.binding.DataObject;
+import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
+import org.openvpp.jvpp.dto.SwInterfaceDetails;
+import org.openvpp.jvpp.future.FutureJVpp;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Customizer for reading sub interfaces form the VPP.
+ */
+public class SubInterfaceCustomizer extends FutureJVppCustomizer
+ implements ChildReaderCustomizer<SubInterface, SubInterfaceBuilder> {
+
+ private static final Logger LOG = LoggerFactory.getLogger(SubInterfaceCustomizer.class);
+ private NamingContext interfaceContext;
+
+ public SubInterfaceCustomizer(@Nonnull final FutureJVpp jvpp,
+ @Nonnull final NamingContext interfaceContext) {
+ super(jvpp);
+ this.interfaceContext = Preconditions.checkNotNull(interfaceContext, "interfaceContext should not be null");
+ }
+
+ @Override
+ public void merge(@Nonnull final Builder<? extends DataObject> parentBuilder,
+ @Nonnull final SubInterface readValue) {
+ ((VppInterfaceStateAugmentationBuilder) parentBuilder).setSubInterface(readValue);
+ }
+
+ @Nonnull
+ @Override
+ public SubInterfaceBuilder getBuilder(@Nonnull final InstanceIdentifier<SubInterface> id) {
+ return new SubInterfaceBuilder();
+ }
+
+ @Override
+ public void readCurrentAttributes(@Nonnull final InstanceIdentifier<SubInterface> id,
+ @Nonnull final SubInterfaceBuilder builder, @Nonnull final Context ctx)
+ throws ReadFailedException {
+ final InterfaceKey key = id.firstKeyOf(Interface.class);
+ // Relying here that parent InterfaceCustomizer was invoked first (PREORDER)
+ // to fill in the context with initial ifc mapping
+ final int index = interfaceContext.getIndex(key.getName());
+ if (!isInterfaceOfType(ctx, index, org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.SubInterface.class)) {
+ return;
+ }
+
+ LOG.debug("Reading attributes for sub interface: {}", id);
+ final SwInterfaceDetails iface = InterfaceUtils.getVppInterfaceDetails(getFutureJVpp(), key, index, ctx);
+ LOG.debug("VPP interface details: {}", ReflectionToStringBuilder.toString(iface));
+
+ if (iface.subId == 0) {
+ // Not a sub interface type
+ return;
+ }
+
+ builder.setIdentifier(Long.valueOf(iface.subId));
+ builder.setSuperInterface(interfaceContext.getName(iface.supSwIfIndex));
+ builder.setNumberOfTags(Short.valueOf(iface.subNumberOfTags));
+ builder.setVlanType(iface.subDot1Ad == 1 ? VlanType._802dot1q : VlanType._802dot1ad);
+ if (iface.subExactMatch == 1) {
+ builder.setExactMatch(true);
+ }
+ if (iface.subDefault == 1) {
+ builder.setDefaultSubif(true);
+ }
+ if (iface.subOuterVlanIdAny == 1) {
+ builder.setMatchAnyOuterId(true);
+ }
+ if (iface.subOuterVlanIdAny == 1) {
+ builder.setMatchAnyInnerId(true);
+ }
+ if (iface.subOuterVlanId != 0) { // optional
+ builder.setOuterId(new VlanTag(Integer.valueOf(iface.subOuterVlanId)));
+ }
+ if (iface.subInnerVlanId != 0) { // optional
+ builder.setInnerId(new VlanTag(Integer.valueOf(iface.subInnerVlanId)));
+ }
+ }
+}
diff --git a/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/SubInterfaceCustomizerTest.java b/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/SubInterfaceCustomizerTest.java
new file mode 100644
index 000000000..d70654655
--- /dev/null
+++ b/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/SubInterfaceCustomizerTest.java
@@ -0,0 +1,189 @@
+/*
+ * Copyright (c) 2016 Cisco and/or its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.fd.honeycomb.v3po.translate.v3po.interfaces;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.verify;
+import static org.mockito.MockitoAnnotations.initMocks;
+
+import io.fd.honeycomb.v3po.translate.v3po.util.NamingContext;
+import io.fd.honeycomb.v3po.translate.v3po.util.VppApiInvocationException;
+import io.fd.honeycomb.v3po.translate.write.WriteContext;
+import io.fd.honeycomb.v3po.translate.write.WriteFailedException;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Mock;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.Interfaces;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.Interface;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.InterfaceKey;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VlanTag;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VlanType;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VppInterfaceAugmentation;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.interfaces._interface.SubInterface;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.interfaces._interface.SubInterfaceBuilder;
+import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
+import org.openvpp.jvpp.dto.CreateSubif;
+import org.openvpp.jvpp.dto.CreateSubifReply;
+import org.openvpp.jvpp.future.FutureJVpp;
+
+public class SubInterfaceCustomizerTest {
+
+ @Mock
+ private FutureJVpp api;
+ @Mock
+ private WriteContext writeContext;
+
+ private NamingContext namingContext;
+ private SubInterfaceCustomizer customizer;
+ public static final String SUPER_IF_NAME = "local0";
+ public static final int SUPER_IF_ID = 1;
+
+ @Before
+ public void setUp() throws Exception {
+ initMocks(this);
+ InterfaceTypeTestUtils.setupWriteContext(writeContext,
+ org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.SubInterface.class);
+ namingContext = new NamingContext("generatedSubInterfaceName");
+ // TODO create base class for tests using vppApi
+ customizer = new SubInterfaceCustomizer(api, namingContext);
+ namingContext.addName(SUPER_IF_ID, SUPER_IF_NAME);
+ }
+
+ private SubInterface generateSubInterface(final String superIfName) {
+ SubInterfaceBuilder builder = new SubInterfaceBuilder();
+ builder.setVlanType(VlanType._802dot1q);
+ builder.setIdentifier(11L);
+ builder.setNumberOfTags((short)1);
+ builder.setOuterId(new VlanTag(100));
+ builder.setInnerId(new VlanTag(200));
+ builder.setSuperInterface(superIfName);
+ return builder.build();
+ }
+
+ private CreateSubif generateSubInterfaceRequest(final int superIfId) {
+ CreateSubif request = new CreateSubif();
+ request.subId = 11;
+ request.swIfIndex = superIfId;
+ request.oneTag = 1;
+ request.dot1Ad = 1;
+ request.outerVlanId = 100;
+ request.innerVlanId = 200;
+ return request;
+ }
+
+ private InstanceIdentifier<SubInterface> getSubInterfaceId(final String name) {
+ return InstanceIdentifier.create(Interfaces.class).child(Interface.class, new InterfaceKey(name)).augmentation(
+ VppInterfaceAugmentation.class).child(SubInterface.class);
+ }
+
+ private void whenCreateSubifThen(final int retval) throws ExecutionException, InterruptedException {
+ final CompletableFuture<CreateSubifReply> replyFuture = new CompletableFuture<>();
+ final CreateSubifReply reply = new CreateSubifReply();
+ reply.retval = retval;
+ replyFuture.complete(reply);
+ doReturn(replyFuture).when(api).createSubif(any(CreateSubif.class));
+ }
+
+ private void whenCreateSubifThenSuccess() throws ExecutionException, InterruptedException {
+ whenCreateSubifThen(0);
+ }
+
+ private void whenCreateSubifThenFailure() throws ExecutionException, InterruptedException {
+ whenCreateSubifThen(-1);
+ }
+
+ private CreateSubif verifyCreateSubifWasInvoked(final CreateSubif expected) {
+ ArgumentCaptor<CreateSubif> argumentCaptor = ArgumentCaptor.forClass(CreateSubif.class);
+ verify(api).createSubif(argumentCaptor.capture());
+ final CreateSubif actual = argumentCaptor.getValue();
+
+ assertEquals(expected.swIfIndex, actual.swIfIndex);
+ assertEquals(expected.subId, actual.subId);
+ assertEquals(expected.noTags, actual.noTags);
+ assertEquals(expected.oneTag, actual.oneTag);
+ assertEquals(expected.twoTags, actual.twoTags);
+ assertEquals(expected.dot1Ad, actual.dot1Ad);
+ assertEquals(expected.exactMatch, actual.exactMatch);
+ assertEquals(expected.defaultSub, actual.defaultSub);
+ assertEquals(expected.outerVlanIdAny, actual.outerVlanIdAny);
+ assertEquals(expected.innerVlanIdAny, actual.innerVlanIdAny);
+ assertEquals(expected.outerVlanId, actual.outerVlanId);
+ assertEquals(expected.innerVlanId, actual.innerVlanId);
+ return actual;
+ }
+
+ @Test
+ public void testCreate() throws Exception {
+ final SubInterface subInterface = generateSubInterface(SUPER_IF_NAME);
+ final String subIfaceName = "local0.sub1";
+ final InstanceIdentifier<SubInterface> id = getSubInterfaceId(subIfaceName);
+
+ whenCreateSubifThenSuccess();
+
+ customizer.writeCurrentAttributes(id, subInterface, writeContext);
+
+ verifyCreateSubifWasInvoked(generateSubInterfaceRequest(SUPER_IF_ID));
+ assertTrue(namingContext.containsIndex(subIfaceName));
+ }
+
+ @Test
+ public void testCreateFailed() throws Exception {
+ final SubInterface subInterface = generateSubInterface(SUPER_IF_NAME);
+ final String subIfaceName = "local0.sub1";
+ final InstanceIdentifier<SubInterface> id = getSubInterfaceId(subIfaceName);
+
+ whenCreateSubifThenFailure();
+
+ try {
+ customizer.writeCurrentAttributes(id, subInterface, writeContext);
+ } catch (WriteFailedException.CreateFailedException e) {
+ assertEquals(VppApiInvocationException.class, e.getCause().getClass());
+ verifyCreateSubifWasInvoked(generateSubInterfaceRequest(SUPER_IF_ID));
+ assertFalse(namingContext.containsIndex(subIfaceName));
+ return;
+ }
+ fail("WriteFailedException.CreateFailedException was expected");
+ }
+
+ @Test
+ public void testUpdateNoChange() throws Exception {
+ final SubInterface before = generateSubInterface(SUPER_IF_NAME);
+ final SubInterface after = generateSubInterface(SUPER_IF_NAME);
+ customizer.updateCurrentAttributes(null, before, after, writeContext);
+ }
+
+ @Test(expected = UnsupportedOperationException.class)
+ public void testUpdate() throws Exception {
+ final SubInterface before = generateSubInterface("eth0");
+ final SubInterface after = generateSubInterface("eth1");
+ customizer.updateCurrentAttributes(null, before, after, writeContext);
+ }
+
+ @Test(expected = UnsupportedOperationException.class)
+ public void testDelete() throws Exception {
+ final SubInterface subInterface = generateSubInterface("eth0");
+ customizer.deleteCurrentAttributes(null, subInterface, writeContext);
+ }
+} \ No newline at end of file
diff --git a/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtilsTest.java b/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtilsTest.java
index 0a0eff03b..6832fe018 100644
--- a/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtilsTest.java
+++ b/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtilsTest.java
@@ -20,6 +20,7 @@ import static org.junit.Assert.assertEquals;
import org.junit.Test;
import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.iana._if.type.rev140508.EthernetCsmacd;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.SubInterface;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.Tap;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VhostUser;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VxlanTunnel;
@@ -47,6 +48,7 @@ public class InterfaceUtilsTest {
assertEquals(Tap.class, InterfaceUtils.getInterfaceType("tap0"));
assertEquals(VxlanTunnel.class, InterfaceUtils.getInterfaceType("vxlan0"));
assertEquals(VhostUser.class, InterfaceUtils.getInterfaceType("VirtualEthernet0/0/0"));
+ assertEquals(SubInterface.class, InterfaceUtils.getInterfaceType("eth0.0"));
assertEquals(EthernetCsmacd.class, InterfaceUtils.getInterfaceType("local0"));
}
} \ No newline at end of file
diff --git a/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/SubInterfaceCustomizerTest.java b/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/SubInterfaceCustomizerTest.java
new file mode 100644
index 000000000..211f818ea
--- /dev/null
+++ b/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/SubInterfaceCustomizerTest.java
@@ -0,0 +1,102 @@
+/*
+ * Copyright (c) 2016 Cisco and/or its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.fd.honeycomb.v3po.translate.v3po.interfacesstate;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+
+import io.fd.honeycomb.v3po.translate.Context;
+import io.fd.honeycomb.v3po.translate.read.ReadFailedException;
+import io.fd.honeycomb.v3po.translate.spi.read.ChildReaderCustomizer;
+import io.fd.honeycomb.v3po.translate.v3po.test.ChildReaderCustomizerTest;
+import io.fd.honeycomb.v3po.translate.v3po.util.NamingContext;
+import java.util.HashMap;
+import java.util.Map;
+import org.junit.Test;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.InterfacesState;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state.Interface;
+import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state.InterfaceKey;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VlanType;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VppInterfaceStateAugmentation;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.VppInterfaceStateAugmentationBuilder;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.interfaces.state._interface.SubInterface;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev150105.interfaces.state._interface.SubInterfaceBuilder;
+import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
+import org.openvpp.jvpp.dto.SwInterfaceDetails;
+
+public class SubInterfaceCustomizerTest extends ChildReaderCustomizerTest<SubInterface, SubInterfaceBuilder> {
+
+ private NamingContext interfacesContext;
+
+ public SubInterfaceCustomizerTest() {
+ super(SubInterface.class);
+ }
+
+ @Override
+ protected ChildReaderCustomizer<SubInterface, SubInterfaceBuilder> initCustomizer() {
+ return new SubInterfaceCustomizer(api, interfacesContext);
+ }
+
+ @Override
+ public void setUpBefore() {
+ interfacesContext = new NamingContext("generatedIfaceName");
+ }
+
+ private InstanceIdentifier<SubInterface> getSubInterfaceId(final String name) {
+ return InstanceIdentifier.create(InterfacesState.class).child(Interface.class, new InterfaceKey(name)).augmentation(
+ VppInterfaceStateAugmentation.class).child(
+ SubInterface.class);
+ }
+
+ @Test
+ public void testMerge() {
+ final VppInterfaceStateAugmentationBuilder builder = mock(VppInterfaceStateAugmentationBuilder.class);
+ final SubInterface value = mock(SubInterface.class);
+ getCustomizer().merge(builder, value);
+ verify(builder).setSubInterface(value);
+ }
+
+ @Test
+ public void testRead() throws ReadFailedException {
+ final Context ctx = new Context();
+ final Map<Integer, SwInterfaceDetails> cachedInterfaceDump = new HashMap<>();
+ final int ifId = 1;
+ final String ifName = "eth0.sub0";
+ interfacesContext.addName(ifId, ifName);
+ final SwInterfaceDetails ifaceDetails = new SwInterfaceDetails();
+ ifaceDetails.subId = ifId;
+ ifaceDetails.interfaceName = ifName.getBytes();
+ cachedInterfaceDump.put(ifId, ifaceDetails);
+ ctx.put(InterfaceCustomizer.DUMPED_IFCS_CONTEXT_KEY, cachedInterfaceDump);
+
+ final SubInterfaceBuilder builder = mock(SubInterfaceBuilder.class);
+ getCustomizer().readCurrentAttributes(getSubInterfaceId(ifName), builder, ctx);
+
+ verify(builder).setIdentifier((long)ifId);
+ verify(builder).setSuperInterface(interfacesContext.getArtificialName(0));
+ verify(builder).setNumberOfTags((short)0);
+ verify(builder).setVlanType(VlanType._802dot1ad);
+ verify(builder, never()).setExactMatch(any());
+ verify(builder, never()).setDefaultSubif(any());
+ verify(builder, never()).setMatchAnyOuterId(any());
+ verify(builder, never()).setMatchAnyInnerId(any());
+ verify(builder, never()).setInnerId(any());
+ verify(builder, never()).setOuterId(any());
+ }
+} \ No newline at end of file