summaryrefslogtreecommitdiffstats
path: root/infra/minimal-distribution-core
diff options
context:
space:
mode:
authorMarek Gradzki <mgradzki@cisco.com>2017-11-22 11:17:15 +0100
committerMarek Gradzki <mgradzki@cisco.com>2017-11-22 11:17:17 +0100
commit0827063002d7fc50b787f1e5f6bbbbdc09802787 (patch)
treed3eb2daea6d3ef1491c8f6be88c7b20cdad8f30d /infra/minimal-distribution-core
parent564ba4dc10dcde369ee4f76055c1bd8ab6cfbad9 (diff)
Add missing @Override annotations
Fix isses reported by Sonar thanks to IntelliJ's code inspection. Change-Id: Ief7b4307d4b90e107f010d7feaa307776afaf947 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Diffstat (limited to 'infra/minimal-distribution-core')
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java1
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/ConfigAndOperationalPipelineModule.java1
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java3
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/HoneycombDOMDataBrokerProvider.java1
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/PersistingDataTreeProvider.java7
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/context/HoneycombContextDOMDataBrokerProvider.java1
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/initializer/InitializerPipelineModule.java1
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaModule.java1
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaServiceProvider.java3
-rw-r--r--infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/YangBindingProviderModule.java1
10 files changed, 20 insertions, 0 deletions
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java
index b22e885..29e79a2 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java
@@ -24,6 +24,7 @@ import net.jmob.guice.conf.core.ConfigurationModule;
*/
public class CfgAttrsModule extends AbstractModule {
+ @Override
protected void configure() {
install(ConfigurationModule.create());
// Inject non-dependency configuration
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/ConfigAndOperationalPipelineModule.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/ConfigAndOperationalPipelineModule.java
index c1e67a5..080caaf 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/ConfigAndOperationalPipelineModule.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/ConfigAndOperationalPipelineModule.java
@@ -45,6 +45,7 @@ public class ConfigAndOperationalPipelineModule extends PrivateModule {
public static final String HONEYCOMB_CONFIG_NONPERSIST = "honeycomb-config-nopersist";
public static final String HONEYCOMB_CONFIG = "honeycomb-config";
+ @Override
protected void configure() {
bind(ShutdownHandler.class).to(ShutdownHandlerImpl.class).in(Singleton.class);
expose(ShutdownHandler.class);
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java
index 225102e..039a0ad 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java
@@ -32,6 +32,7 @@ public abstract class DataTreeProvider extends ProviderTrait<DataTree> {
@Inject
private HoneycombConfiguration config;
+ @Override
public TipProducingDataTree create() {
TipProducingDataTree delegate = InMemoryDataTreeFactory.getInstance().create(getType());
delegate.setSchemaContext(schemaService.getGlobalContext());
@@ -41,6 +42,7 @@ public abstract class DataTreeProvider extends ProviderTrait<DataTree> {
public abstract TreeType getType();
public static class ConfigDataTreeProvider extends DataTreeProvider {
+ @Override
public TreeType getType() {
return TreeType.CONFIGURATION;
}
@@ -48,6 +50,7 @@ public abstract class DataTreeProvider extends ProviderTrait<DataTree> {
}
public static class ContextDataTreeProvider extends DataTreeProvider {
+ @Override
public TreeType getType() {
return TreeType.OPERATIONAL;
}
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/HoneycombDOMDataBrokerProvider.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/HoneycombDOMDataBrokerProvider.java
index c23530d..ca94350 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/HoneycombDOMDataBrokerProvider.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/HoneycombDOMDataBrokerProvider.java
@@ -30,6 +30,7 @@ public final class HoneycombDOMDataBrokerProvider extends ProviderTrait<DOMDataB
@Inject(optional = true)
private ReadableDataManager readDataManager;
+ @Override
protected DataBroker create() {
return readDataManager != null
? DataBroker.create(modDataManager, readDataManager)
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/PersistingDataTreeProvider.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/PersistingDataTreeProvider.java
index 4e940d6..9da3a00 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/PersistingDataTreeProvider.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/PersistingDataTreeProvider.java
@@ -34,6 +34,7 @@ public abstract class PersistingDataTreeProvider extends ProviderTrait<DataTree>
@Inject
protected HoneycombConfiguration config;
+ @Override
public DataTree create() {
return isEnabled()
? new PersistingDataTreeAdapter(getDelegate(), schemaService, Paths.get(getPath()))
@@ -54,14 +55,17 @@ public abstract class PersistingDataTreeProvider extends ProviderTrait<DataTree>
@Named(ConfigAndOperationalPipelineModule.HONEYCOMB_CONFIG_NONPERSIST)
private DataTree delegate;
+ @Override
public String getPath() {
return config.peristConfigPath;
}
+ @Override
public TreeType getType() {
return TreeType.CONFIGURATION;
}
+ @Override
public DataTree getDelegate() {
return delegate;
}
@@ -78,14 +82,17 @@ public abstract class PersistingDataTreeProvider extends ProviderTrait<DataTree>
@Named(ContextPipelineModule.HONEYCOMB_CONTEXT_NOPERSIST)
private DataTree delegate;
+ @Override
public String getPath() {
return config.peristContextPath;
}
+ @Override
public TreeType getType() {
return TreeType.OPERATIONAL;
}
+ @Override
public DataTree getDelegate() {
return delegate;
}
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/context/HoneycombContextDOMDataBrokerProvider.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/context/HoneycombContextDOMDataBrokerProvider.java
index 1ceed92..4c3965f 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/context/HoneycombContextDOMDataBrokerProvider.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/context/HoneycombContextDOMDataBrokerProvider.java
@@ -27,6 +27,7 @@ public final class HoneycombContextDOMDataBrokerProvider extends ProviderTrait<D
@Inject
private ModifiableDataManager modDataManager;
+ @Override
public DataBroker create() {
return DataBroker.create(modDataManager);
}
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/initializer/InitializerPipelineModule.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/initializer/InitializerPipelineModule.java
index e0c38f3..0ddcf2e 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/initializer/InitializerPipelineModule.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/initializer/InitializerPipelineModule.java
@@ -30,6 +30,7 @@ public final class InitializerPipelineModule extends PrivateModule {
public static final String HONEYCOMB_INITIALIZER = "honeycomb-initializer";
+ @Override
protected void configure() {
// Create data tree manager on top of non-persisting config data tree
bind(ModifiableDataManager.class).toProvider(ModifiableDTDelegInitProvider.class).in(Singleton.class);
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaModule.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaModule.java
index c84724f..7e6b89d 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaModule.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaModule.java
@@ -24,6 +24,7 @@ import org.opendaylight.mdsal.binding.generator.impl.ModuleInfoBackedContext;
public class SchemaModule extends AbstractModule {
+ @Override
protected void configure() {
bind(ModuleInfoBackedContext.class).toProvider(ModuleInfoBackedCtxProvider.class).in(Singleton.class);
bind(SchemaService.class).toProvider(SchemaServiceProvider.class).in(Singleton.class);
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaServiceProvider.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaServiceProvider.java
index ec4a303..4ed3698 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaServiceProvider.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/SchemaServiceProvider.java
@@ -30,6 +30,7 @@ public final class SchemaServiceProvider extends ProviderTrait<SchemaService> {
@Inject
private ModuleInfoBackedContext mibCtx;
+ @Override
public StaticSchemaService create() {
return new StaticSchemaService(mibCtx.getSchemaContext());
}
@@ -69,8 +70,10 @@ public final class SchemaServiceProvider extends ProviderTrait<SchemaService> {
final SchemaContextListener listener) {
listener.onGlobalContextUpdated(schemaContext);
return new ListenerRegistration<SchemaContextListener>() {
+ @Override
public void close() {}
+ @Override
public SchemaContextListener getInstance() {
return listener;
}
diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/YangBindingProviderModule.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/YangBindingProviderModule.java
index d705226..d43485f 100644
--- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/YangBindingProviderModule.java
+++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/YangBindingProviderModule.java
@@ -23,6 +23,7 @@ import org.slf4j.LoggerFactory;
public class YangBindingProviderModule extends AbstractModule {
private static final Logger LOG = LoggerFactory.getLogger(YangBindingProviderModule.class);
+ @Override
protected void configure() {
LOG.info("Configuring YangBindingProviderModule");
bind(YangModulesProvider.YangModules.class).toProvider(YangModulesProvider.class).asEagerSingleton();