From 30332456b6c581085bb17d619ebb74c36e01c357 Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Thu, 14 Dec 2017 13:32:14 +0100 Subject: Add Logger for RpcRegistryImpl Change-Id: I6ef0133f0128fbf5cfb9ed9f0e738af0bda3a852 Signed-off-by: Marek Gradzki --- infra/rpc/impl/pom.xml | 9 ++++----- .../src/main/java/io/fd/honeycomb/rpc/RpcRegistryBuilder.java | 5 +++++ 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/infra/rpc/impl/pom.xml b/infra/rpc/impl/pom.xml index 395b5f0c8..30d544def 100644 --- a/infra/rpc/impl/pom.xml +++ b/infra/rpc/impl/pom.xml @@ -48,6 +48,10 @@ future-converter-java8-guava 0.3.0 + + org.slf4j + slf4j-api + @@ -65,10 +69,5 @@ mockito-core test - - org.slf4j - slf4j-api - test - diff --git a/infra/rpc/impl/src/main/java/io/fd/honeycomb/rpc/RpcRegistryBuilder.java b/infra/rpc/impl/src/main/java/io/fd/honeycomb/rpc/RpcRegistryBuilder.java index 0b96be0a3..ca6441ee8 100644 --- a/infra/rpc/impl/src/main/java/io/fd/honeycomb/rpc/RpcRegistryBuilder.java +++ b/infra/rpc/impl/src/main/java/io/fd/honeycomb/rpc/RpcRegistryBuilder.java @@ -25,6 +25,8 @@ import javax.annotation.Nullable; import org.opendaylight.controller.md.sal.dom.api.DOMRpcImplementationNotAvailableException; import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.model.api.SchemaPath; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public final class RpcRegistryBuilder { @@ -40,6 +42,7 @@ public final class RpcRegistryBuilder { private static final class RpcRegistryImpl implements RpcRegistry { + private static final Logger LOG = LoggerFactory.getLogger(RpcRegistryImpl.class); private final Map services; private RpcRegistryImpl(@Nonnull final Map services) { @@ -51,11 +54,13 @@ public final class RpcRegistryBuilder { public CompletionStage invoke(@Nonnull final SchemaPath schemaPath, @Nullable final DataObject request) { final RpcService rpcService = services.get(schemaPath); if (rpcService == null) { + LOG.error("Missing Rpc service for schemaPath: {}", schemaPath); final CompletableFuture result = new CompletableFuture<>(); result.completeExceptionally( new DOMRpcImplementationNotAvailableException("Service not found: %s", schemaPath)); return result; } + LOG.debug("Delegating rpcRequest: {} to rpcService: {}", request, rpcService); return rpcService.invoke(request); } -- cgit 1.2.3-korg