From 4ef356196e7b37790e595b99d59f007f4484a818 Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Sat, 17 Sep 2016 23:00:54 +0200 Subject: HONEYCOMB-196: unit test for LispModule Increases test coverage of lisp plugin to approximately 43%. Change-Id: I2d60eae05dab9c4277f1b601616b9be4262de7eb Signed-off-by: Marek Gradzki --- common/impl-parent/pom.xml | 7 ++ lisp/lisp2vpp/pom.xml | 10 +++ .../java/io/fd/honeycomb/lisp/LispModuleTest.java | 96 ++++++++++++++++++++++ v3po/v3po2vpp/pom.xml | 5 -- 4 files changed, 113 insertions(+), 5 deletions(-) create mode 100644 lisp/lisp2vpp/src/test/java/io/fd/honeycomb/lisp/LispModuleTest.java diff --git a/common/impl-parent/pom.xml b/common/impl-parent/pom.xml index d3e1bd561..6c46aa67e 100644 --- a/common/impl-parent/pom.xml +++ b/common/impl-parent/pom.xml @@ -38,6 +38,7 @@ 2.0.2-Beryllium-SR2 1.0.2-Beryllium-SR2 1.0.8 + 1.3 @@ -91,6 +92,12 @@ ${guice.version} test + + org.hamcrest + hamcrest-all + ${hamcrest.version} + test + diff --git a/lisp/lisp2vpp/pom.xml b/lisp/lisp2vpp/pom.xml index 3a5942ad5..3553a2a07 100755 --- a/lisp/lisp2vpp/pom.xml +++ b/lisp/lisp2vpp/pom.xml @@ -89,5 +89,15 @@ mockito-all test + + com.google.inject.extensions + guice-testlib + test + + + org.hamcrest + hamcrest-all + test + diff --git a/lisp/lisp2vpp/src/test/java/io/fd/honeycomb/lisp/LispModuleTest.java b/lisp/lisp2vpp/src/test/java/io/fd/honeycomb/lisp/LispModuleTest.java new file mode 100644 index 000000000..29fbc5cd7 --- /dev/null +++ b/lisp/lisp2vpp/src/test/java/io/fd/honeycomb/lisp/LispModuleTest.java @@ -0,0 +1,96 @@ +/* + * Copyright (c) 2016 Cisco and/or its affiliates. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at: + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package io.fd.honeycomb.lisp; + +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.CoreMatchers.not; +import static org.hamcrest.Matchers.empty; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertThat; +import static org.mockito.MockitoAnnotations.initMocks; + +import com.google.inject.Guice; +import com.google.inject.Inject; +import com.google.inject.name.Named; +import com.google.inject.testing.fieldbinder.Bind; +import com.google.inject.testing.fieldbinder.BoundFieldModule; +import io.fd.honeycomb.translate.read.ReaderFactory; +import io.fd.honeycomb.translate.util.read.registry.CompositeReaderRegistryBuilder; +import io.fd.honeycomb.translate.util.write.registry.FlatWriterRegistryBuilder; +import io.fd.honeycomb.translate.v3po.util.NamingContext; +import io.fd.honeycomb.translate.write.WriterFactory; +import java.util.HashSet; +import java.util.Set; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mock; +import org.opendaylight.controller.md.sal.binding.api.DataBroker; +import org.openvpp.jvpp.core.future.FutureJVppCore; + +public class LispModuleTest { + + @Named("interface-context") + @Bind + private NamingContext interfaceContext; + + @Named("honeycomb-context") + @Bind + @Mock + private DataBroker honeycombContext; + + @Named("honeycomb-initializer") + @Bind + @Mock + private DataBroker honeycombInitializer; + + @Bind + @Mock + private FutureJVppCore futureJVppCore; + + @Inject + private Set readerFactories = new HashSet<>(); + + @Inject + private Set writerFactories = new HashSet<>(); + + @Before + public void setUp() throws Exception { + initMocks(this); + interfaceContext = new NamingContext("interfaceContext", "interfaceContext"); + Guice.createInjector(new LispModule(), BoundFieldModule.of(this)).injectMembers(this); + } + + @Test + public void testReaderFactories() throws Exception { + assertThat(readerFactories, is(not(empty()))); + + // Test registration process (all dependencies present, topological order of readers does exist, etc.) + final CompositeReaderRegistryBuilder registryBuilder = new CompositeReaderRegistryBuilder(); + readerFactories.stream().forEach(factory -> factory.init(registryBuilder)); + assertNotNull(registryBuilder.build()); + } + + @Test + public void testWriterFactories() throws Exception { + assertThat(writerFactories, is(not(empty()))); + + // Test registration process (all dependencies present, topological order of writers does exist, etc.) + final FlatWriterRegistryBuilder registryBuilder = new FlatWriterRegistryBuilder(); + writerFactories.stream().forEach(factory -> factory.init(registryBuilder)); + assertNotNull(registryBuilder.build()); + } +} \ No newline at end of file diff --git a/v3po/v3po2vpp/pom.xml b/v3po/v3po2vpp/pom.xml index 25196d754..21b0aeb08 100644 --- a/v3po/v3po2vpp/pom.xml +++ b/v3po/v3po2vpp/pom.xml @@ -28,10 +28,6 @@ 1.16.12-SNAPSHOT bundle - - 1.3 - - io.fd.honeycomb @@ -112,7 +108,6 @@ org.hamcrest hamcrest-all - ${hamcrest.version} test -- cgit 1.2.3-korg