From 1326e9fa5cffe326b82aeee9d82d008526aff947 Mon Sep 17 00:00:00 2001
From: Maros Marsalek <mmarsale@cisco.com>
Date: Mon, 5 Sep 2016 12:10:26 +0200
Subject: Cleanup TODOs and FIXMEs

- Fix minor ones
- Report bigger and include issue number in comment
- Pull common dependencies into dependency management of common/parents

Change-Id: I06a6ac37c52b603fd73ed42023d6b2e7fa18010f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
---
 common/impl-parent/pom.xml | 50 ++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 48 insertions(+), 2 deletions(-)

(limited to 'common/impl-parent')

diff --git a/common/impl-parent/pom.xml b/common/impl-parent/pom.xml
index fbcd4c8f7..8a04b4b8f 100644
--- a/common/impl-parent/pom.xml
+++ b/common/impl-parent/pom.xml
@@ -34,8 +34,53 @@
     <nexusproxy>http://nexus.fd.io/content</nexusproxy>
     <guice.version>4.1.0</guice.version>
     <guice.config.version>1.2.0</guice.config.version>
+    <mdsal.controller.version>1.3.2-Beryllium-SR2</mdsal.controller.version>
+    <mdsal.version>2.0.2-Beryllium-SR2</mdsal.version>
+    <netconf.version>1.0.2-Beryllium-SR2</netconf.version>
   </properties>
 
+  <dependencyManagement>
+    <dependencies>
+      <dependency>
+        <groupId>org.opendaylight.controller</groupId>
+        <artifactId>mdsal-artifacts</artifactId>
+        <version>${mdsal.controller.version}</version>
+        <type>pom</type>
+        <scope>import</scope>
+      </dependency>
+      <dependency>
+        <groupId>org.opendaylight.mdsal</groupId>
+        <artifactId>mdsal-artifacts</artifactId>
+        <version>${mdsal.version}</version>
+        <type>pom</type>
+        <scope>import</scope>
+      </dependency>
+      <dependency>
+        <groupId>org.opendaylight.netconf</groupId>
+        <artifactId>netconf-artifacts</artifactId>
+        <version>${netconf.version}</version>
+        <type>pom</type>
+        <scope>import</scope>
+      </dependency>
+      <!-- DI -->
+      <dependency>
+        <groupId>com.google.inject</groupId>
+        <artifactId>guice</artifactId>
+        <version>${guice.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>net.jmob</groupId>
+        <artifactId>guice.conf</artifactId>
+        <version>${guice.config.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>com.google.inject.extensions</groupId>
+        <artifactId>guice-multibindings</artifactId>
+        <version>${guice.version}</version>
+      </dependency>
+    </dependencies>
+  </dependencyManagement>
+
   <build>
     <pluginManagement>
       <plugins>
@@ -45,7 +90,7 @@
             <!-- Override checkstyle configuration to fit Honeycomb coding style-->
             <configLocation>honeycomb-checkstyle.xml</configLocation>
             <includeTestResources>true</includeTestResources>
-            <!--TODO enable fail on violation after issues are resolved + set in as errors in checkstyle xml-->
+            <!--TODO HONEYCOMB-155 enable fail on violation after issues are resolved + set in as errors in checkstyle xml-->
           </configuration>
           <executions>
 
@@ -105,7 +150,7 @@
           </dependencies>
         </plugin>
         <!-- Deactivate strict java8 checks -->
-        <!-- FIXME fix all the javadoc offenders of doclint -->
+        <!-- TODO HONEYCOMB-156 fix all the javadoc offenders of doclint -->
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-javadoc-plugin</artifactId>
@@ -160,6 +205,7 @@
     </plugins>
   </build>
 
+
   <distributionManagement>
     <repository>
       <id>fdio-release</id>
-- 
cgit 1.2.3-korg