From 819618ee3920c8277509bc2add888328c722cf10 Mon Sep 17 00:00:00 2001 From: Michal Cmarada Date: Mon, 8 Oct 2018 09:51:04 +0200 Subject: HONEYCOMB-431: add support for RPC This patch introduces ValidableTransaction interface, used by Honeycomb's DataBroker to implement Netconf's DOMDataTransactionValidator. WriteTransaction implements ValidableTransaction by delegating validate to DataModification for both config and operational modifications. This patch requires ODL Fluorine (HONEYCOMB-433), which brings support for validation to Netconf. Alternatively custom ODL Oxygen build with patches from stable/oxygen/oxygen-hc-improvements. Change-Id: Ic3eaffaef0314d22da3ea37f9416f18ccb0b99ae Signed-off-by: Marek Gradzki Signed-off-by: Michal Cmarada --- .../honeycomb/data/impl/ValidableTransaction.java | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 infra/data-impl/src/main/java/io/fd/honeycomb/data/impl/ValidableTransaction.java (limited to 'infra/data-impl/src/main/java/io/fd/honeycomb/data/impl/ValidableTransaction.java') diff --git a/infra/data-impl/src/main/java/io/fd/honeycomb/data/impl/ValidableTransaction.java b/infra/data-impl/src/main/java/io/fd/honeycomb/data/impl/ValidableTransaction.java new file mode 100644 index 000000000..0c67f863f --- /dev/null +++ b/infra/data-impl/src/main/java/io/fd/honeycomb/data/impl/ValidableTransaction.java @@ -0,0 +1,45 @@ +/* + * Copyright (c) 2018 Cisco and/or its affiliates. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at: + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package io.fd.honeycomb.data.impl; + +import com.google.common.annotations.Beta; +import com.google.common.util.concurrent.CheckedFuture; +import org.opendaylight.controller.md.sal.dom.api.DOMDataWriteTransaction; +import org.opendaylight.netconf.mdsal.connector.DOMDataTransactionValidator; +import org.opendaylight.netconf.mdsal.connector.DOMDataTransactionValidator.ValidationFailedException; + +/** + * An {@link DOMDataWriteTransaction} than can be validated. + * @see DOMDataTransactionValidator + */ +@Beta +interface ValidableTransaction extends DOMDataWriteTransaction { + /** + * Validates state of the data tree associated with the provided {@link DOMDataWriteTransaction}. + * + *

The operation should not have any side-effects on the transaction state. + * + *

It can be executed many times, providing the same results + * if the state of the transaction has not been changed. + * + * @return + * a CheckedFuture containing the result of the validate operation. The future blocks until the validation + * operation is complete. A successful validate returns nothing. On failure, the Future will fail + * with a {@link ValidationFailedException} or an exception derived from ValidationFailedException. + */ + CheckedFuture validate(); +} -- cgit 1.2.3-korg