From 1326e9fa5cffe326b82aeee9d82d008526aff947 Mon Sep 17 00:00:00 2001
From: Maros Marsalek <mmarsale@cisco.com>
Date: Mon, 5 Sep 2016 12:10:26 +0200
Subject: Cleanup TODOs and FIXMEs

- Fix minor ones
- Report bigger and include issue number in comment
- Pull common dependencies into dependency management of common/parents

Change-Id: I06a6ac37c52b603fd73ed42023d6b2e7fa18010f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
---
 infra/it/it-test/pom.xml                                         | 9 ++++++---
 .../io/fd/honeycomb/data/impl/HoneycombSubtreeReadInfraTest.java | 4 ++--
 .../java/io/fd/honeycomb/data/impl/HoneycombWriteInfraTest.java  | 2 +-
 infra/it/pom.xml                                                 | 1 +
 4 files changed, 10 insertions(+), 6 deletions(-)

(limited to 'infra/it')

diff --git a/infra/it/it-test/pom.xml b/infra/it/it-test/pom.xml
index 5cde7b00b..5a55c339f 100644
--- a/infra/it/it-test/pom.xml
+++ b/infra/it/it-test/pom.xml
@@ -28,6 +28,10 @@
     <artifactId>honeycomb-it-test</artifactId>
     <version>1.16.12-SNAPSHOT</version>
 
+    <properties>
+        <skinny.logback.version>1.0.8</skinny.logback.version>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>${project.groupId}</groupId>
@@ -40,9 +44,10 @@
             <version>${project.version}</version>
         </dependency>
         <dependency>
+            <!-- We want logs from these tests -->
             <groupId>org.skinny-framework</groupId>
             <artifactId>skinny-logback</artifactId>
-            <version>1.0.8</version>
+            <version>${skinny.logback.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>
@@ -61,6 +66,4 @@
             <version>${project.version}</version>
         </dependency>
     </dependencies>
-
-
 </project>
\ No newline at end of file
diff --git a/infra/it/it-test/src/test/java/io/fd/honeycomb/data/impl/HoneycombSubtreeReadInfraTest.java b/infra/it/it-test/src/test/java/io/fd/honeycomb/data/impl/HoneycombSubtreeReadInfraTest.java
index a43f70a84..5bb81b477 100644
--- a/infra/it/it-test/src/test/java/io/fd/honeycomb/data/impl/HoneycombSubtreeReadInfraTest.java
+++ b/infra/it/it-test/src/test/java/io/fd/honeycomb/data/impl/HoneycombSubtreeReadInfraTest.java
@@ -68,7 +68,7 @@ public class HoneycombSubtreeReadInfraTest extends AbstractInfraTest {
                         public List<ListInContainerKey> getAllIds(@Nonnull final InstanceIdentifier<ListInContainer> id,
                                                                   @Nonnull final ReadContext context)
                                 throws ReadFailedException {
-                            // FIXME this is the only way of extending subtree reader via its list child
+                            // This is the only way of extending subtree reader's list child
                             // Reflexive list reader has to be used in place of the list(managed by subtree reader perent)
                             // to enable further children readers. However, it will not work out of the box, because
                             // reflexive list reader has no way to tell what are the IDs to correctly invoke its children.
@@ -89,7 +89,7 @@ public class HoneycombSubtreeReadInfraTest extends AbstractInfraTest {
     private Reader<ContainerInList, ContainerInListBuilder> containerInListReader =
             HoneycombReadInfraTest.mockReader(Ids.CONTAINER_IN_LIST_ID, this::readContainerInList, ContainerInListBuilder.class);
 
-    // TODO Test subtree readers especially composite structure where readers are under subtree reader
+    // TODO HONEYCOMB-178 Test subtree readers especially composite structure where readers are under subtree reader
 
     @Override
     void postSetup() {
diff --git a/infra/it/it-test/src/test/java/io/fd/honeycomb/data/impl/HoneycombWriteInfraTest.java b/infra/it/it-test/src/test/java/io/fd/honeycomb/data/impl/HoneycombWriteInfraTest.java
index 90a18dd7a..fe679d14f 100644
--- a/infra/it/it-test/src/test/java/io/fd/honeycomb/data/impl/HoneycombWriteInfraTest.java
+++ b/infra/it/it-test/src/test/java/io/fd/honeycomb/data/impl/HoneycombWriteInfraTest.java
@@ -169,7 +169,7 @@ public class HoneycombWriteInfraTest extends AbstractInfraTest {
 
     private void verifyOrderedWrites(final Writer<?>[] orderedWriters, final InOrder inOrder)
             throws WriteFailedException {
-        // TODO Modifications are not produced for nodes that do not contain any actual leaves (except when choice is a child) do we need those triggers ?
+        // Modifications are not produced for nodes that do not contain any actual leaves (except when choice is a child)
         // Unordered
         // verify(complexAugmentWriter).update(eq(COMPLEX_AUGMENT_ID), eq(null), eq(getComplexAugment()), any(WriteContext.class));
         // 1
diff --git a/infra/it/pom.xml b/infra/it/pom.xml
index 93265ee61..6151ec6ac 100644
--- a/infra/it/pom.xml
+++ b/infra/it/pom.xml
@@ -24,6 +24,7 @@
   <prerequisites>
     <maven>3.1.1</maven>
   </prerequisites>
+
   <modules>
     <module>test-model</module>
     <module>it-test</module>
-- 
cgit 1.2.3-korg