From 0827063002d7fc50b787f1e5f6bbbbdc09802787 Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Wed, 22 Nov 2017 11:17:15 +0100 Subject: Add missing @Override annotations Fix isses reported by Sonar thanks to IntelliJ's code inspection. Change-Id: Ief7b4307d4b90e107f010d7feaa307776afaf947 Signed-off-by: Marek Gradzki --- .../java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java | 1 + .../infra/distro/data/ConfigAndOperationalPipelineModule.java | 1 + .../java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java | 3 +++ .../infra/distro/data/HoneycombDOMDataBrokerProvider.java | 1 + .../fd/honeycomb/infra/distro/data/PersistingDataTreeProvider.java | 7 +++++++ .../distro/data/context/HoneycombContextDOMDataBrokerProvider.java | 1 + .../infra/distro/initializer/InitializerPipelineModule.java | 1 + .../java/io/fd/honeycomb/infra/distro/schema/SchemaModule.java | 1 + .../io/fd/honeycomb/infra/distro/schema/SchemaServiceProvider.java | 3 +++ .../honeycomb/infra/distro/schema/YangBindingProviderModule.java | 1 + 10 files changed, 20 insertions(+) (limited to 'infra/minimal-distribution-core') diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java index b22e88593..29e79a2a9 100644 --- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java +++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/cfgattrs/CfgAttrsModule.java @@ -24,6 +24,7 @@ import net.jmob.guice.conf.core.ConfigurationModule; */ public class CfgAttrsModule extends AbstractModule { + @Override protected void configure() { install(ConfigurationModule.create()); // Inject non-dependency configuration diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/ConfigAndOperationalPipelineModule.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/ConfigAndOperationalPipelineModule.java index c1e67a5df..080caaf81 100644 --- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/ConfigAndOperationalPipelineModule.java +++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/ConfigAndOperationalPipelineModule.java @@ -45,6 +45,7 @@ public class ConfigAndOperationalPipelineModule extends PrivateModule { public static final String HONEYCOMB_CONFIG_NONPERSIST = "honeycomb-config-nopersist"; public static final String HONEYCOMB_CONFIG = "honeycomb-config"; + @Override protected void configure() { bind(ShutdownHandler.class).to(ShutdownHandlerImpl.class).in(Singleton.class); expose(ShutdownHandler.class); diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java index 225102e1a..039a0ad82 100644 --- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java +++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/DataTreeProvider.java @@ -32,6 +32,7 @@ public abstract class DataTreeProvider extends ProviderTrait { @Inject private HoneycombConfiguration config; + @Override public TipProducingDataTree create() { TipProducingDataTree delegate = InMemoryDataTreeFactory.getInstance().create(getType()); delegate.setSchemaContext(schemaService.getGlobalContext()); @@ -41,6 +42,7 @@ public abstract class DataTreeProvider extends ProviderTrait { public abstract TreeType getType(); public static class ConfigDataTreeProvider extends DataTreeProvider { + @Override public TreeType getType() { return TreeType.CONFIGURATION; } @@ -48,6 +50,7 @@ public abstract class DataTreeProvider extends ProviderTrait { } public static class ContextDataTreeProvider extends DataTreeProvider { + @Override public TreeType getType() { return TreeType.OPERATIONAL; } diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/HoneycombDOMDataBrokerProvider.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/HoneycombDOMDataBrokerProvider.java index c23530d57..ca9435081 100644 --- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/HoneycombDOMDataBrokerProvider.java +++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/HoneycombDOMDataBrokerProvider.java @@ -30,6 +30,7 @@ public final class HoneycombDOMDataBrokerProvider extends ProviderTrait @Inject protected HoneycombConfiguration config; + @Override public DataTree create() { return isEnabled() ? new PersistingDataTreeAdapter(getDelegate(), schemaService, Paths.get(getPath())) @@ -54,14 +55,17 @@ public abstract class PersistingDataTreeProvider extends ProviderTrait @Named(ConfigAndOperationalPipelineModule.HONEYCOMB_CONFIG_NONPERSIST) private DataTree delegate; + @Override public String getPath() { return config.peristConfigPath; } + @Override public TreeType getType() { return TreeType.CONFIGURATION; } + @Override public DataTree getDelegate() { return delegate; } @@ -78,14 +82,17 @@ public abstract class PersistingDataTreeProvider extends ProviderTrait @Named(ContextPipelineModule.HONEYCOMB_CONTEXT_NOPERSIST) private DataTree delegate; + @Override public String getPath() { return config.peristContextPath; } + @Override public TreeType getType() { return TreeType.OPERATIONAL; } + @Override public DataTree getDelegate() { return delegate; } diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/context/HoneycombContextDOMDataBrokerProvider.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/context/HoneycombContextDOMDataBrokerProvider.java index 1ceed92c1..4c3965f35 100644 --- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/context/HoneycombContextDOMDataBrokerProvider.java +++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/data/context/HoneycombContextDOMDataBrokerProvider.java @@ -27,6 +27,7 @@ public final class HoneycombContextDOMDataBrokerProvider extends ProviderTrait { @Inject private ModuleInfoBackedContext mibCtx; + @Override public StaticSchemaService create() { return new StaticSchemaService(mibCtx.getSchemaContext()); } @@ -69,8 +70,10 @@ public final class SchemaServiceProvider extends ProviderTrait { final SchemaContextListener listener) { listener.onGlobalContextUpdated(schemaContext); return new ListenerRegistration() { + @Override public void close() {} + @Override public SchemaContextListener getInstance() { return listener; } diff --git a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/YangBindingProviderModule.java b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/YangBindingProviderModule.java index d705226bf..d43485f7e 100644 --- a/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/YangBindingProviderModule.java +++ b/infra/minimal-distribution-core/src/main/java/io/fd/honeycomb/infra/distro/schema/YangBindingProviderModule.java @@ -23,6 +23,7 @@ import org.slf4j.LoggerFactory; public class YangBindingProviderModule extends AbstractModule { private static final Logger LOG = LoggerFactory.getLogger(YangBindingProviderModule.class); + @Override protected void configure() { LOG.info("Configuring YangBindingProviderModule"); bind(YangModulesProvider.YangModules.class).toProvider(YangModulesProvider.class).asEagerSingleton(); -- cgit 1.2.3-korg