From a3d562afdd96d4c37fe608af99f364e879ee92b6 Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Thu, 13 Jul 2017 10:41:27 +0200 Subject: HONEYCOMB-369: configurable BGP peers BGP peer configuration is no longer read from bgp-peer.json file. Netconf/Restconf is can be used instead. BGP peer configuration in HC follows openconfig-extensions model (as in ODL BGP): * http://docs.opendaylight.org/en/stable-boron/user-guide/bgp-user-guide.html#bgp-peering * http://docs.opendaylight.org/en/stable-boron/user-guide/bgp-user-guide.html#bgp-application-peer-and-programmable-rib Change-Id: I91aa6c4fc0923edbacf6cd10abd3957569a4f8c6 Signed-off-by: Marek Gradzki --- .../infra/bgp/neighbors/NeighborCustomizer.java | 139 +++++++++++++++++++++ 1 file changed, 139 insertions(+) create mode 100644 infra/northbound/bgp/src/main/java/io/fd/honeycomb/infra/bgp/neighbors/NeighborCustomizer.java (limited to 'infra/northbound/bgp/src/main/java/io/fd/honeycomb/infra/bgp/neighbors/NeighborCustomizer.java') diff --git a/infra/northbound/bgp/src/main/java/io/fd/honeycomb/infra/bgp/neighbors/NeighborCustomizer.java b/infra/northbound/bgp/src/main/java/io/fd/honeycomb/infra/bgp/neighbors/NeighborCustomizer.java new file mode 100644 index 000000000..50ae45b40 --- /dev/null +++ b/infra/northbound/bgp/src/main/java/io/fd/honeycomb/infra/bgp/neighbors/NeighborCustomizer.java @@ -0,0 +1,139 @@ +/* + * Copyright (c) 2017 Cisco and/or its affiliates. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at: + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package io.fd.honeycomb.infra.bgp.neighbors; + +import static com.google.common.base.Preconditions.checkNotNull; +import static com.google.common.base.Preconditions.checkState; +import static org.opendaylight.protocol.bgp.openconfig.impl.util.OpenConfigUtil.APPLICATION_PEER_GROUP_NAME; + +import com.google.common.annotations.VisibleForTesting; +import io.fd.honeycomb.translate.spi.write.ListWriterCustomizer; +import io.fd.honeycomb.translate.write.WriteContext; +import io.fd.honeycomb.translate.write.WriteFailedException; +import java.util.HashMap; +import java.util.Map; +import javax.annotation.Nonnull; +import javax.annotation.concurrent.GuardedBy; +import javax.annotation.concurrent.ThreadSafe; +import org.opendaylight.protocol.bgp.openconfig.spi.BGPOpenConfigMappingService; +import org.opendaylight.protocol.bgp.rib.impl.config.AppPeer; +import org.opendaylight.protocol.bgp.rib.impl.config.BgpPeer; +import org.opendaylight.protocol.bgp.rib.impl.config.PeerBean; +import org.opendaylight.protocol.bgp.rib.impl.spi.BGPPeerRegistry; +import org.opendaylight.protocol.bgp.rib.impl.spi.RIB; +import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009.BgpNeighborPeerGroupConfig; +import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009.bgp.neighbors.Neighbor; +import org.opendaylight.yang.gen.v1.http.openconfig.net.yang.bgp.rev151009.bgp.neighbors.NeighborKey; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.openconfig.extensions.rev160614.Config2; +import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Writer responsible for management of BGP Neighbors. Partially based on BgpDeployerImpl from ODL's BGP (was hard to + * use directly due to OSGI dependencies). + */ +@ThreadSafe +final class NeighborCustomizer implements ListWriterCustomizer { + private static final Logger LOG = LoggerFactory.getLogger(NeighborCustomizer.class); + private final RIB globalRib; + private final BGPPeerRegistry peerRegistry; + private final BGPOpenConfigMappingService mappingService; + + @GuardedBy("this") + private final Map, PeerBean> peers = new HashMap<>(); + + public NeighborCustomizer(@Nonnull final RIB globalRib, @Nonnull final BGPPeerRegistry peerRegistry, + @Nonnull final BGPOpenConfigMappingService mappingService) { + this.globalRib = checkNotNull(globalRib, "globalRib should not be null"); + this.peerRegistry = checkNotNull(peerRegistry, "globalRib should not be null"); + this.mappingService = checkNotNull(mappingService, "globalRib should not be null"); + } + + @VisibleForTesting + synchronized void addPeer(@Nonnull final InstanceIdentifier id, + @Nonnull final PeerBean peer) { + peers.put(id, peer); + } + + @VisibleForTesting + synchronized boolean isPeerConfigured(@Nonnull final InstanceIdentifier id) { + return peers.containsKey(id); + } + + @Override + public synchronized void writeCurrentAttributes(@Nonnull final InstanceIdentifier id, + @Nonnull final Neighbor neighbor, + @Nonnull final WriteContext writeContext) + throws WriteFailedException { + final PeerBean peer; + if (isApplicationPeer(neighbor)) { + LOG.debug("Creating AppPeer bean for {}: {}", id, neighbor); + peer = new AppPeer(); + } else { + LOG.debug("Starting BgpPeer bean for {}: {}", id, neighbor); + peer = new BgpPeer(null, peerRegistry); + } + LOG.debug("Starting bgp peer for {}", id); + peer.start(globalRib, neighbor, mappingService, null); + addPeer(id, peer); + } + + @Override + public synchronized void updateCurrentAttributes(@Nonnull final InstanceIdentifier id, + @Nonnull final Neighbor dataBefore, + @Nonnull final Neighbor dataAfter, + @Nonnull final WriteContext writeContext) + throws WriteFailedException { + LOG.debug("Updating Peer instance {} with configuration: {}", id, dataAfter); + final PeerBean peer = peers.get(id); + checkState(peer != null, "Could not find peer bean while updating neighbor {}", id); + closePeerBean(peer); + peer.start(globalRib, dataAfter, mappingService, null); + LOG.debug("Peer instance updated {}", peer); + } + + @Override + public synchronized void deleteCurrentAttributes(@Nonnull final InstanceIdentifier id, + @Nonnull final Neighbor dataBefore, + @Nonnull final WriteContext writeContext) + throws WriteFailedException { + LOG.debug("Removing Peer instance: {}", id); + final PeerBean peer = peers.remove(id); + if (peer != null) { + closePeerBean(peer); + LOG.debug("Peer instance removed {}", peer); + } + } + + private static boolean isApplicationPeer(@Nonnull final Neighbor neighbor) { + return java.util.Optional.of(neighbor.getConfig()) + .map(config -> config.getAugmentation(Config2.class)) + .map(BgpNeighborPeerGroupConfig::getPeerGroup) + .map(APPLICATION_PEER_GROUP_NAME::equals) + .orElse(false); + } + + private static void closePeerBean(final PeerBean peer) { + try { + peer.closeServiceInstance().get(); + } catch (final Exception e) { + LOG.error("Peer instance failed to close service instance", e); + } + peer.close(); + } +} -- cgit 1.2.3-korg