From e7a8d81ce8ba43384b42a98b0ded5769e89fe1be Mon Sep 17 00:00:00 2001 From: Maros Marsalek Date: Mon, 12 Sep 2016 13:48:48 +0200 Subject: HONEYCOMB-194 Raise test coverage for translate-api to 80% Change-Id: I6f055ae926aaf876863adb7eddadde0abefdda91 Signed-off-by: Maros Marsalek --- .../java/io/fd/honeycomb/translate/TranslationException.java | 10 +++++----- .../java/io/fd/honeycomb/translate/write/DataObjectUpdate.java | 5 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) (limited to 'infra/translate-api/src/main') diff --git a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/TranslationException.java b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/TranslationException.java index 6037391e2..1aef7d01c 100644 --- a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/TranslationException.java +++ b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/TranslationException.java @@ -19,17 +19,17 @@ package io.fd.honeycomb.translate; import com.google.common.annotations.Beta; /** - * Base exception for the translation layer + * Base exception for the translation layer. */ @Beta public class TranslationException extends Exception { - public TranslationException(final String s) { - super(s); + public TranslationException(final String message) { + super(message); } - public TranslationException(final String s, final Throwable cause) { - super(s, cause); + public TranslationException(final String message, final Throwable cause) { + super(message, cause); } public TranslationException(final Throwable cause) { diff --git a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/DataObjectUpdate.java b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/DataObjectUpdate.java index e76d76fcd..583c7b781 100644 --- a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/DataObjectUpdate.java +++ b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/DataObjectUpdate.java @@ -57,8 +57,8 @@ public class DataObjectUpdate { } public static DataObjectUpdate create(@Nonnull final InstanceIdentifier id, - @Nullable final DataObject dataBefore, - @Nullable final DataObject dataAfter) { + @Nullable final DataObject dataBefore, + @Nullable final DataObject dataAfter) { checkArgument(!(dataBefore == null && dataAfter == null), "Both before and after data are null"); if (dataBefore != null) { checkArgument(id.getTargetType().isAssignableFrom(dataBefore.getClass())); @@ -84,7 +84,6 @@ public class DataObjectUpdate { final DataObjectUpdate that = (DataObjectUpdate) o; return id.equals(that.id); - } @Override -- cgit 1.2.3-korg