From ca6abb7ac148362b74d29c062df80d0ad67e723f Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Wed, 22 Nov 2017 15:38:23 +0100 Subject: Make fields of UpdateFailedException transient Exceptions are Serializable. Fields of Serializable class must be either Serializable or transient. But DataObjects are not serializable, and there is really no reason to serialize UpdateFailedException. This patch excludes fields of the UpdateFailedException from serialization process to fix Sonar warnings. Change-Id: I1eb9408289241bb4fe6f712ed9208f8460eef317 Signed-off-by: Marek Gradzki --- .../honeycomb/translate/write/registry/UpdateFailedException.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'infra/translate-api/src') diff --git a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/registry/UpdateFailedException.java b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/registry/UpdateFailedException.java index efb8dd524..c5848f20d 100644 --- a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/registry/UpdateFailedException.java +++ b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/registry/UpdateFailedException.java @@ -23,12 +23,15 @@ import javax.annotation.Nonnull; /** * Thrown when CRUD operation fails. + * + * Serialization/deserialization of this exception would cause + * {@link #getProcessed()} and {@link #getFailed()} to return null. */ public class UpdateFailedException extends TranslationException { private static final long serialVersionUID = 896331856485410043L; - private final List processed; - private final DataObjectUpdate failed; + private transient final List processed; + private transient final DataObjectUpdate failed; /** * @param cause original cause of failure -- cgit 1.2.3-korg