From e9d3785d0603bf6e024affafc735641ee312b675 Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Thu, 9 Aug 2018 10:07:36 +0200 Subject: AbstractGenericWriter: remove xxxCurrent methods Use xxxCurrentAttributes instead to simplify call graph. Change-Id: I8201b115354dddd35ca0b63b2c72dfb4eac93646 Signed-off-by: Marek Gradzki --- .../translate/impl/write/GenericListWriter.java | 31 ++++------------------ 1 file changed, 5 insertions(+), 26 deletions(-) (limited to 'infra/translate-impl') diff --git a/infra/translate-impl/src/main/java/io/fd/honeycomb/translate/impl/write/GenericListWriter.java b/infra/translate-impl/src/main/java/io/fd/honeycomb/translate/impl/write/GenericListWriter.java index 5121eb793..ff683b810 100644 --- a/infra/translate-impl/src/main/java/io/fd/honeycomb/translate/impl/write/GenericListWriter.java +++ b/infra/translate-impl/src/main/java/io/fd/honeycomb/translate/impl/write/GenericListWriter.java @@ -85,30 +85,14 @@ public final class GenericListWriter, K e } @Override - protected void writeCurrent(final InstanceIdentifier id, final D data, final WriteContext ctx) - throws WriteFailedException { - super.writeCurrent(getManagedId(id, data), data, ctx); - } - - @Override - protected void updateCurrent(final InstanceIdentifier id, final D dataBefore, final D dataAfter, - final WriteContext ctx) throws WriteFailedException { - super.updateCurrent(getManagedId(id, dataBefore), dataBefore, dataAfter, ctx); - } - - @Override - protected void deleteCurrent(final InstanceIdentifier id, final D dataBefore, final WriteContext ctx) - throws WriteFailedException { - super.deleteCurrent(getManagedId(id, dataBefore), dataBefore, ctx); - } - - @Override - protected InstanceIdentifier getManagedId(@Nonnull final InstanceIdentifier currentId, - @Nonnull final D current) { + @SuppressWarnings("unchecked") + protected InstanceIdentifier getSpecificId(@Nonnull final InstanceIdentifier currentId, + @Nonnull final D current) { final InstanceIdentifier id = (InstanceIdentifier) currentId; // Make sure the key is present if (isWildcarded(id)) { - return getSpecificId(id, current); + return RWUtils.replaceLastInId(id, + new InstanceIdentifier.IdentifiableItem<>(id.getTargetType(), current.getKey())); } else { return id; } @@ -117,9 +101,4 @@ public final class GenericListWriter, K e private boolean isWildcarded(final InstanceIdentifier id) { return id.firstIdentifierOf(getManagedDataObjectType().getTargetType()).isWildcarded(); } - - private InstanceIdentifier getSpecificId(final InstanceIdentifier currentId, final D current) { - return RWUtils.replaceLastInId(currentId, - new InstanceIdentifier.IdentifiableItem<>(currentId.getTargetType(), current.getKey())); - } } -- cgit 1.2.3-korg