From 75dc8820ecfb9212b9ab1b4f3d87056f32d7e48b Mon Sep 17 00:00:00 2001 From: Marek Gradzki Date: Mon, 5 Sep 2016 10:47:45 +0200 Subject: Fix ReaderFactory: remove AutoClosable from list of implemented interfaces. Reader factories do not need to be AutoClosable. Change-Id: I779e87eb0b03750e264df52e14eee58467ca799a Signed-off-by: Marek Gradzki --- .../java/io/fd/honeycomb/impl/NetconfMonitoringReaderFactory.java | 5 +++-- .../main/java/io/fd/honeycomb/translate/read/ReaderFactory.java | 7 +------ 2 files changed, 4 insertions(+), 8 deletions(-) (limited to 'infra') diff --git a/infra/impl/src/main/java/io/fd/honeycomb/impl/NetconfMonitoringReaderFactory.java b/infra/impl/src/main/java/io/fd/honeycomb/impl/NetconfMonitoringReaderFactory.java index a299dbe3f..244ae585e 100644 --- a/infra/impl/src/main/java/io/fd/honeycomb/impl/NetconfMonitoringReaderFactory.java +++ b/infra/impl/src/main/java/io/fd/honeycomb/impl/NetconfMonitoringReaderFactory.java @@ -15,6 +15,7 @@ */ package io.fd.honeycomb.impl; +import io.fd.honeycomb.translate.read.ReaderFactory; import io.fd.honeycomb.translate.read.registry.ModifiableReaderRegistryBuilder; import io.fd.honeycomb.translate.util.read.BindingBrokerReader; import org.opendaylight.controller.md.sal.binding.api.DataBroker; @@ -24,10 +25,10 @@ import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.mon import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; /** - * {@link io.fd.honeycomb.translate.read.ReaderFactory} initiating reader into NETCONF's dedicated data store. + * {@link ReaderFactory} initiating reader into NETCONF's dedicated data store. * Making NETCONF operational data available over NETCONF/RESTCONF */ -public final class NetconfMonitoringReaderFactory implements AutoCloseable, io.fd.honeycomb.translate.read.ReaderFactory { +public final class NetconfMonitoringReaderFactory implements ReaderFactory { private final DataBroker netconfMonitoringBindingBrokerDependency; diff --git a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/read/ReaderFactory.java b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/read/ReaderFactory.java index 701a26dd5..658e2460f 100644 --- a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/read/ReaderFactory.java +++ b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/read/ReaderFactory.java @@ -24,15 +24,10 @@ import javax.annotation.Nonnull; * Factory producing readers for {@link ModifiableReaderRegistryBuilder}. */ @Beta -public interface ReaderFactory extends AutoCloseable { +public interface ReaderFactory { /** * Initialize 1 or more readers and add them to provided registry. */ void init(@Nonnull ModifiableReaderRegistryBuilder registry); - - @Override - default void close() { - // NOOP TODO allow unregister - } } -- cgit 1.2.3-korg