From f15aed916c69b0766c7bed2dc7fe534f48b97ac9 Mon Sep 17 00:00:00 2001 From: Maros Marsalek Date: Thu, 14 Jul 2016 10:41:49 +0200 Subject: HONEYCOMB-122: Reader registry integration tests Add IT test for read infrastructure + some additional unit tests + Make Read/Write Factory autoCloseable Change-Id: I6eab8e6df2c2132af01cea0a9c4b9bece7dc9b74 Signed-off-by: Maros Marsalek --- .../java/io/fd/honeycomb/v3po/translate/read/ReaderFactory.java | 7 ++++++- .../java/io/fd/honeycomb/v3po/translate/write/WriterFactory.java | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) (limited to 'v3po/translate-api') diff --git a/v3po/translate-api/src/main/java/io/fd/honeycomb/v3po/translate/read/ReaderFactory.java b/v3po/translate-api/src/main/java/io/fd/honeycomb/v3po/translate/read/ReaderFactory.java index 6d6d52acc..61472f8d2 100644 --- a/v3po/translate-api/src/main/java/io/fd/honeycomb/v3po/translate/read/ReaderFactory.java +++ b/v3po/translate-api/src/main/java/io/fd/honeycomb/v3po/translate/read/ReaderFactory.java @@ -24,10 +24,15 @@ import javax.annotation.Nonnull; * Factory producing readers for {@link ModifiableReaderRegistryBuilder}. */ @Beta -public interface ReaderFactory { +public interface ReaderFactory extends AutoCloseable { /** * Initialize 1 or more readers and add them to provided registry. */ void init(@Nonnull ModifiableReaderRegistryBuilder registry); + + @Override + default void close() { + // NOOP TODO allow unregister + } } diff --git a/v3po/translate-api/src/main/java/io/fd/honeycomb/v3po/translate/write/WriterFactory.java b/v3po/translate-api/src/main/java/io/fd/honeycomb/v3po/translate/write/WriterFactory.java index dfcffa47f..ffc76a0e4 100644 --- a/v3po/translate-api/src/main/java/io/fd/honeycomb/v3po/translate/write/WriterFactory.java +++ b/v3po/translate-api/src/main/java/io/fd/honeycomb/v3po/translate/write/WriterFactory.java @@ -24,10 +24,15 @@ import javax.annotation.Nonnull; * Factory producing writers for {@link ModifiableWriterRegistryBuilder}. */ @Beta -public interface WriterFactory { +public interface WriterFactory extends AutoCloseable { /** * Initialize 1 or more writers and add them to provided registry. */ void init(@Nonnull ModifiableWriterRegistryBuilder registry); + + @Override + default void close() { + // NOOP TODO allow unregister + } } -- cgit 1.2.3-korg