From c54ae4ac74d6b8ab71c7e166f10ca6b080ffa558 Mon Sep 17 00:00:00 2001 From: Jan Srnicek Date: Thu, 13 Oct 2016 16:58:22 +0200 Subject: Caching for Ipv4 addresses fixed also for readCurrentAttributes Caching scope fixed also in specific request logic Added test Change-Id: Ib70a3069cf7620132ae5921ddb21b56fa2f4108b Signed-off-by: Jan Srnicek --- .../translate/v3po/interfacesstate/ip/Ipv4AddressCustomizer.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'v3po/v3po2vpp/src/main/java/io') diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfacesstate/ip/Ipv4AddressCustomizer.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfacesstate/ip/Ipv4AddressCustomizer.java index 0cd9032b6..8b1fb86e9 100644 --- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfacesstate/ip/Ipv4AddressCustomizer.java +++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfacesstate/ip/Ipv4AddressCustomizer.java @@ -78,8 +78,10 @@ public class Ipv4AddressCustomizer extends FutureJVppCustomizer final String interfaceName = id.firstKeyOf(Interface.class).getName(); final int interfaceIndex = interfaceContext.getIndex(interfaceName, ctx.getMappingContext()); + // Key needs to contain interface ID to distinguish dumps between interfaces + final String cacheKey = CACHE_KEY + interfaceName; final Optional dumpOptional = dumpManager - .getDump(id, CACHE_KEY, ctx.getModificationCache(), new AddressDumpParams(interfaceIndex, false)); + .getDump(id, cacheKey, ctx.getModificationCache(), new AddressDumpParams(interfaceIndex, false)); if (!dumpOptional.isPresent() || dumpOptional.get().ipAddressDetails.isEmpty()) { return; -- cgit 1.2.3-korg