From 05b2bf2e31a90d97425230dcbf2bca6df54519ff Mon Sep 17 00:00:00 2001 From: Neale Ranns Date: Mon, 30 Jan 2017 06:44:58 -0800 Subject: MFIB Coverity warnings. The lock macro is functionally equivalent but more expressive (and might appease coverity) Change-Id: Ie3c9b2896a487a0302903bfbdd6348f6f091c67d Signed-off-by: Neale Ranns --- src/vnet/mfib/mfib_test.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src/vnet/mfib/mfib_test.c') diff --git a/src/vnet/mfib/mfib_test.c b/src/vnet/mfib/mfib_test.c index 8735bfa7..8082a6bb 100644 --- a/src/vnet/mfib/mfib_test.c +++ b/src/vnet/mfib/mfib_test.c @@ -235,6 +235,7 @@ mfib_test_entry (fib_node_index_t fei, const replicate_t *rep; mfib_prefix_t pfx; va_list ap; + int res; va_start(ap, n_buckets); @@ -253,12 +254,11 @@ mfib_test_entry (fib_node_index_t fei, "%U links to %U", format_mfib_prefix, &pfx, format_dpo_id, &mfe->mfe_rep, 0); - return (!0); + res = !0; } else { dpo_id_t tmp = DPO_INVALID; - int res; mfib_entry_contribute_forwarding( fei, @@ -274,9 +274,11 @@ mfib_test_entry (fib_node_index_t fei, res = mfib_test_validate_rep_v(rep, n_buckets, ap); dpo_reset(&tmp); - - return (res); } + + va_end(ap); + + return (res); } static int -- cgit 1.2.3-korg