From 0f1c29c9d45edcc2d226a8e519db3e56888e3181 Mon Sep 17 00:00:00 2001 From: Florin Coras Date: Tue, 26 Jul 2016 12:12:17 +0200 Subject: Fix Coverty warning in lisp_add_del_map_resolver_command_fn Change-Id: I074d9e026ae42aa14caedc56287816ab64968425 Signed-off-by: Florin Coras --- vnet/vnet/lisp-cp/control.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'vnet') diff --git a/vnet/vnet/lisp-cp/control.c b/vnet/vnet/lisp-cp/control.c index bea37004..78e730f5 100644 --- a/vnet/vnet/lisp-cp/control.c +++ b/vnet/vnet/lisp-cp/control.c @@ -2175,7 +2175,7 @@ lisp_add_del_map_resolver_command_fn (vlib_main_t * vm, vlib_cli_command_t * cmd) { unformat_input_t _line_input, * line_input = &_line_input; - u8 is_add = 1; + u8 is_add = 1, addr_set = 0; ip_address_t ip_addr; clib_error_t * error = 0; int rv = 0; @@ -2192,13 +2192,20 @@ lisp_add_del_map_resolver_command_fn (vlib_main_t * vm, else if (unformat (line_input, "del")) is_add = 0; else if (unformat (line_input, "%U", unformat_ip_address, &ip_addr)) - ; + addr_set = 1; else { error = unformat_parse_error(line_input); goto done; } } + + if (!addr_set) + { + error = clib_error_return(0, "Map-resolver address must be set!"); + goto done; + } + a->is_add = is_add; a->address = ip_addr; rv = vnet_lisp_add_del_map_resolver (a); -- cgit 1.2.3-korg