diff options
| author |   Karol Latecki <karolx.latecki@intel.com> | 2016-10-19 18:54:18 -0400 |
|---|---|---|
| committer | Karol Latecki <karolx.latecki@intel.com> | 2016-10-21 10:42:35 +0200 |
| commit | 663163e519820b1a4ece0368d9932186cd803f5a (patch) | |
| tree | 62a60486a66bc159a8a175c8917c2fb0644c38a9 | |
| parent | 7a7ef4def34d6a2c9b21a9b4135cedd14fb9f72d (diff) | |
tldk: fix for positive errno return values in udp_ctl.c
'Public' functions should return negative values.
Change-Id: I88eaf76f882eee08a4198543d0c8531656530360
Signed-off-by: Karol Latecki <karolx.latecki@intel.com>
| -rw-r--r-- | lib/libtle_udp/tle_udp_impl.h | 2 | ||||
| -rw-r--r-- | lib/libtle_udp/udp_ctl.c | 4 | ||||
| -rw-r--r-- | test/gtest/test_tle_udp_stream.cpp | 10 |
3 files changed, 8 insertions, 8 deletions
diff --git a/lib/libtle_udp/tle_udp_impl.h b/lib/libtle_udp/tle_udp_impl.h index a0af7ce..c55d605 100644 --- a/lib/libtle_udp/tle_udp_impl.h +++ b/lib/libtle_udp/tle_udp_impl.h @@ -270,7 +270,7 @@ int tle_udp_stream_close(struct tle_udp_stream *s); * Pointer to the stream. * @return * zero on successful completion. - * - EINVAL - invalid parameter passed to function + * - -EINVAL - invalid parameter passed to function */ int tle_udp_stream_get_param(const struct tle_udp_stream *s, diff --git a/lib/libtle_udp/udp_ctl.c b/lib/libtle_udp/udp_ctl.c index e6da8f2..faedcad 100644 --- a/lib/libtle_udp/udp_ctl.c +++ b/lib/libtle_udp/udp_ctl.c @@ -730,7 +730,7 @@ tle_udp_stream_close(struct tle_udp_stream *s) static const struct tle_udp_stream_cb zcb; if (s == NULL || s->type >= TLE_UDP_VNUM) - return EINVAL; + return -EINVAL; ctx = s->ctx; @@ -779,7 +779,7 @@ tle_udp_stream_get_param(const struct tle_udp_stream *s, struct sockaddr_in6 *lin6; if (prm == NULL || s == NULL || s->type >= TLE_UDP_VNUM) - return EINVAL; + return -EINVAL; prm[0] = s->prm; if (prm->local_addr.ss_family == AF_INET) { diff --git a/test/gtest/test_tle_udp_stream.cpp b/test/gtest/test_tle_udp_stream.cpp index 9356288..22a1b44 100644 --- a/test/gtest/test_tle_udp_stream.cpp +++ b/test/gtest/test_tle_udp_stream.cpp @@ -33,7 +33,7 @@ TEST_F(test_tle_udp_stream, stream_test_open_nullctx) EXPECT_EQ(rte_errno, EINVAL); ret = tle_udp_stream_close(stream); - EXPECT_EQ(ret, EINVAL); + EXPECT_EQ(ret, -EINVAL); } TEST_F(test_tle_udp_stream, stream_test_open_null_stream_prm) @@ -43,7 +43,7 @@ TEST_F(test_tle_udp_stream, stream_test_open_null_stream_prm) EXPECT_EQ(rte_errno, EINVAL); ret = tle_udp_stream_close(stream); - EXPECT_EQ(ret, EINVAL); + EXPECT_EQ(ret, -EINVAL); } @@ -77,7 +77,7 @@ TEST_F(test_tle_udp_stream, stream_test_close) TEST_F(test_tle_udp_stream, stream_test_close_null) { ret = tle_udp_stream_close(nullptr); - EXPECT_EQ(ret, EINVAL); + EXPECT_EQ(ret, -EINVAL); } @@ -115,7 +115,7 @@ TEST_F(test_tle_udp_stream, stream_get_param_streamnull) EXPECT_NE(stream, nullptr); ret = tle_udp_stream_get_param(nullptr, &prm); - EXPECT_EQ(ret, EINVAL); + EXPECT_EQ(ret, -EINVAL); } TEST_F(test_tle_udp_stream, stream_get_param_prmnull) @@ -127,7 +127,7 @@ TEST_F(test_tle_udp_stream, stream_get_param_prmnull) EXPECT_NE(stream, nullptr); ret = tle_udp_stream_get_param(stream, nullptr); - EXPECT_EQ(ret, EINVAL); + EXPECT_EQ(ret, -EINVAL); } |