aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeale Ranns <nranns@cisco.com>2020-04-30 13:30:57 +0000
committerAndrew Yourtchenko <ayourtch@gmail.com>2020-04-30 17:20:00 +0000
commit0830008b31104fd5833d8559afc95c6198f7b0e0 (patch)
treeda725501ae7b58717622c5c9e96d81e898b074c6
parent8e4ed521a65a6fcf787a10e34d155e41a7df4f52 (diff)
ipsec: Add/Del SA not MP safe
Type: fix some crytto engines store key data indexed by SA index. Creating new SAs means this store reallocs with packets inflight; bad stuff ensues. Signed-off-by: Neale Ranns <nranns@cisco.com> Change-Id: Ia23c3a59e2d05fb006bdbd9922d01ee192e22853
-rw-r--r--src/vnet/ipsec/ipsec_api.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/src/vnet/ipsec/ipsec_api.c b/src/vnet/ipsec/ipsec_api.c
index abebd5baea3..5dfd6707a01 100644
--- a/src/vnet/ipsec/ipsec_api.c
+++ b/src/vnet/ipsec/ipsec_api.c
@@ -1013,13 +1013,6 @@ ipsec_api_hookup (vlib_main_t * vm)
#undef _
/*
- * Adding and deleting SAs is MP safe since when they are added/delete
- * no traffic is using them
- */
- am->is_mp_safe[VL_API_IPSEC_SAD_ENTRY_ADD_DEL] = 1;
- am->is_mp_safe[VL_API_IPSEC_SAD_ENTRY_ADD_DEL_REPLY] = 1;
-
- /*
* Set up the (msg_name, crc, message-id) table
*/
setup_message_id_table (am);