From 08f8d3dfeaddb16980c77281586caaf476723dfb Mon Sep 17 00:00:00 2001 From: Neale Ranns Date: Thu, 30 Apr 2020 13:30:57 +0000 Subject: ipsec: Add/Del SA not MP safe Type: fix some crytto engines store key data indexed by SA index. Creating new SAs means this store reallocs with packets inflight; bad stuff ensues. Signed-off-by: Neale Ranns Change-Id: Ia23c3a59e2d05fb006bdbd9922d01ee192e22853 --- src/vnet/ipsec/ipsec_api.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/vnet/ipsec/ipsec_api.c b/src/vnet/ipsec/ipsec_api.c index 4252acd2688..b86de045fc9 100644 --- a/src/vnet/ipsec/ipsec_api.c +++ b/src/vnet/ipsec/ipsec_api.c @@ -990,13 +990,6 @@ ipsec_api_hookup (vlib_main_t * vm) foreach_vpe_api_msg; #undef _ - /* - * Adding and deleting SAs is MP safe since when they are added/delete - * no traffic is using them - */ - am->is_mp_safe[VL_API_IPSEC_SAD_ENTRY_ADD_DEL] = 1; - am->is_mp_safe[VL_API_IPSEC_SAD_ENTRY_ADD_DEL_REPLY] = 1; - /* * Set up the (msg_name, crc, message-id) table */ -- cgit 1.2.3-korg