From 2ac41357bc15dce578f67d53c25f2de357185e71 Mon Sep 17 00:00:00 2001 From: Paul Atkins Date: Tue, 19 Jan 2021 15:22:23 +0000 Subject: vppinfra: add defines for bihash add and delete When calling the bihash_add_del... functions some callers add a comment beside the value to indicate this is the is_add param. Make the code easier to read by adding defines for add and delete that the callers can use instead of having to use 0 or 1. Type: improvement Signed-off-by: Paul Atkins Change-Id: Iab5f7c8e8df12ac62fc7e726ca1798622dcdb42c --- src/vppinfra/bihash_doc.h | 2 +- src/vppinfra/bihash_template.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vppinfra/bihash_doc.h b/src/vppinfra/bihash_doc.h index b4b6a4a969b..7c7e5179961 100644 --- a/src/vppinfra/bihash_doc.h +++ b/src/vppinfra/bihash_doc.h @@ -112,7 +112,7 @@ void clib_bihash_free (clib_bihash * h); @param h - the bi-hash table to search @param add_v - the (key,value) pair to add - @param is_add - add=1, delete=0 + @param is_add - add=1 (BIHASH_ADD), delete=0 (BIHASH_DEL) @returns 0 on success, < 0 on error @note This function will replace an existing (key,value) pair if the new key matches an existing key diff --git a/src/vppinfra/bihash_template.h b/src/vppinfra/bihash_template.h index 4ab27aac38f..1ca0ae447f8 100644 --- a/src/vppinfra/bihash_template.h +++ b/src/vppinfra/bihash_template.h @@ -334,6 +334,9 @@ static inline uword BV (clib_bihash_get_offset) (BVT (clib_bihash) * h, return vp - hp; } +#define BIHASH_ADD 1 +#define BIHASH_DEL 0 + void BV (clib_bihash_init) (BVT (clib_bihash) * h, char *name, u32 nbuckets, uword memory_size); -- cgit 1.2.3-korg