From 39382976701926c1f34191c1311829c15a53cb01 Mon Sep 17 00:00:00 2001 From: Steven Luong Date: Tue, 12 Mar 2019 21:35:42 -0700 Subject: vhost-user: restart vpp may cause vhost to crash Fix a typo in vhost_user_rx_discard_packet which may cause txvq->last_avail_idx to go wild. Change-Id: Ifaeb58835dff9b7ea82c061442722f1dcaa5d9a4 Signed-off-by: Steven Luong --- src/vnet/devices/virtio/vhost_user_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vnet/devices/virtio/vhost_user_input.c b/src/vnet/devices/virtio/vhost_user_input.c index 911fde03544..08fc3b1521a 100644 --- a/src/vnet/devices/virtio/vhost_user_input.c +++ b/src/vnet/devices/virtio/vhost_user_input.c @@ -200,7 +200,7 @@ vhost_user_rx_discard_packet (vlib_main_t * vm, u16 last_used_idx = txvq->last_used_idx; while (discarded_packets != discard_max) { - if (avail_idx == txvq->last_avail_idx) + if (avail_idx == last_avail_idx) goto out; u16 desc_chain_head = txvq->avail->ring[last_avail_idx & mask]; -- cgit 1.2.3-korg