From 50328c9d1e2b9a6753d82f3d00f64c48d2b39efd Mon Sep 17 00:00:00 2001 From: Dave Barach Date: Sun, 15 Oct 2017 17:20:40 -0400 Subject: VPP-1031: Fix minor issues in clib_spinlock_unlock() Change-Id: I20ce799c9dd57332c06003b466ee7c36169bce98 Signed-off-by: Dave Barach (cherry picked from commit fa77e8fb1cc8a87a4a31792698e7200c4195583e) --- src/vppinfra/lock.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vppinfra/lock.h b/src/vppinfra/lock.h index 0cd2b4fea53..7d241675b12 100644 --- a/src/vppinfra/lock.h +++ b/src/vppinfra/lock.h @@ -71,12 +71,14 @@ clib_spinlock_lock_if_init (clib_spinlock_t * p) static_always_inline void clib_spinlock_unlock (clib_spinlock_t * p) { - (*p)->lock = 0; #if CLIB_DEBUG > 0 (*p)->frame_address = 0; (*p)->pid = 0; (*p)->thread_index = 0; #endif + /* Make sure all writes are complete before releasing the lock */ + CLIB_MEMORY_BARRIER (); + (*p)->lock = 0; } static_always_inline void -- cgit 1.2.3-korg