From 9fb50d83dbe22cab30532cec8c85e711af1f82ff Mon Sep 17 00:00:00 2001 From: Steven Luong Date: Thu, 18 Jul 2019 18:38:52 -0700 Subject: devices: vhost handling VHOST_USER_SET_FEATURES Some combinations of new qemu (2.11) and old dpdk (16.10) may send VHOST_USER_SET_FEATURES at the end of the protocol exchange which the vhost interface is already declared up and ready. Unfortunately, the process of VHOST_USER_SET_FEATURES will cause the interface to go down. Not sure if it is correct or needed. Because there is no additional messages thereafter, the hardware interface stays down. The fix is to check the interface again at the end of processing VHOST_USER_SET_FEATURES. If it is up and ready, we bring back the hardware interface. Type: fix Change-Id: I490cd03820deacbd8b44d8f2cb38c26349dbe3b2 Signed-off-by: Steven Luong (cherry picked from commit 545866b5b3115b7de114bdb7883f5ece59b702d4) --- src/vnet/devices/virtio/vhost_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vnet/devices/virtio/vhost_user.c b/src/vnet/devices/virtio/vhost_user.c index 1d52b42b73b..f16d015ef5a 100644 --- a/src/vnet/devices/virtio/vhost_user.c +++ b/src/vnet/devices/virtio/vhost_user.c @@ -494,6 +494,7 @@ vhost_user_socket_read (clib_file_t * uf) ASSERT (vui->virtio_net_hdr_sz < VLIB_BUFFER_PRE_DATA_SIZE); vnet_hw_interface_set_flags (vnm, vui->hw_if_index, 0); vui->is_ready = 0; + vhost_user_update_iface_state (vui); break; case VHOST_USER_SET_MEM_TABLE: -- cgit 1.2.3-korg