From a03d25d327ed9db40922cfcf247c3ee793c4754d Mon Sep 17 00:00:00 2001 From: Benoît Ganne Date: Tue, 3 Sep 2019 17:54:21 +0200 Subject: gbp: fix set_mac() in unit tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Do not use low-level sw_interface_set_mac_address() directly and use higher-level set_mac() instead, otherwise interface local_mac and configured mac are out-of-sync Type: fix Fixes: 25b049484f Change-Id: I9366e7afb95ef00e25a94ca3b0e6309871169878 Signed-off-by: Benoît Ganne --- src/plugins/gbp/test/test_gbp.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/plugins/gbp/test/test_gbp.py b/src/plugins/gbp/test/test_gbp.py index 2d7fa459440..cb426492891 100644 --- a/src/plugins/gbp/test/test_gbp.py +++ b/src/plugins/gbp/test/test_gbp.py @@ -872,9 +872,7 @@ class TestGBP(VppTestCase): if epg != epgs[1] and epg != epgs[4]: VppIpInterfaceBind(self, epg.bvi, epg.rd.t4).add_vpp_config() VppIpInterfaceBind(self, epg.bvi, epg.rd.t6).add_vpp_config() - self.vapi.sw_interface_set_mac_address( - epg.bvi.sw_if_index, - self.router_mac.packed) + epg.bvi.set_mac(self.router_mac) # The BVIs are NAT inside interfaces flags = self.config_flags.NAT_IS_INSIDE @@ -2261,9 +2259,7 @@ class TestGBP(VppTestCase): if epg != epgs[1]: VppIpInterfaceBind(self, epg.bvi, epg.rd.t4).add_vpp_config() VppIpInterfaceBind(self, epg.bvi, epg.rd.t6).add_vpp_config() - self.vapi.sw_interface_set_mac_address( - epg.bvi.sw_if_index, - self.router_mac.packed) + epg.bvi.set_mac(self.router_mac) if_ip4 = VppIpInterfaceAddress(self, epg.bvi, epg.bvi_ip4, 32) if_ip6 = VppIpInterfaceAddress(self, epg.bvi, epg.bvi_ip6, 128) -- cgit 1.2.3-korg