From b840c773dc9d7f0f9f85753a20d00acb53a6bce7 Mon Sep 17 00:00:00 2001 From: Benoît Ganne Date: Tue, 10 Sep 2019 18:42:09 +0200 Subject: quic: fix non-null terminated hostname string MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Type: fix Change-Id: I089d359d5726050f32f69366547086216fdb3098 Signed-off-by: Benoît Ganne --- src/plugins/quic/quic.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/plugins/quic/quic.c b/src/plugins/quic/quic.c index 42a839db515..4a465fcbe30 100644 --- a/src/plugins/quic/quic.c +++ b/src/plugins/quic/quic.c @@ -1085,16 +1085,12 @@ quic_connect_new_connection (session_endpoint_cfg_t * sep) ctx->client_opaque = sep->opaque; ctx->c_flags |= TRANSPORT_CONNECTION_F_NO_LOOKUP; if (sep->hostname) - { - ctx->srv_hostname = format (0, "%v", sep->hostname); - vec_terminate_c_string (ctx->srv_hostname); - } + ctx->srv_hostname = format (0, "%v", sep->hostname); else - { - /* needed by quic for crypto + determining client / server */ - ctx->srv_hostname = - format (0, "%U", format_ip46_address, &sep->ip, sep->is_ip4); - } + /* needed by quic for crypto + determining client / server */ + ctx->srv_hostname = + format (0, "%U", format_ip46_address, &sep->ip, sep->is_ip4); + vec_terminate_c_string (ctx->srv_hostname); clib_memcpy (&cargs->sep, sep, sizeof (session_endpoint_cfg_t)); cargs->sep.transport_proto = TRANSPORT_PROTO_UDPC; -- cgit 1.2.3-korg