From fe47e29fc6ddcb664f76f4ebbfd2593cb0282e43 Mon Sep 17 00:00:00 2001 From: Steven Date: Fri, 17 Aug 2018 09:44:08 -0700 Subject: lacp: issue with slave interface admin up after it is added to the bond group [VPP-1409] When the slave interface is admin up after it is added to the bond group, lacp does not send lacp pdu's to the interface because its periodic timer is not running. The issue was the slave interface's variables got reset after the state machines were initialized. Change-Id: I2942556ce29a4acc97db3be40293e69bed7b6679 Signed-off-by: Steven (cherry picked from commit bf21dc85053931bc597e0fab1112061aa60e986b) --- src/plugins/lacp/lacp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/lacp/lacp.c b/src/plugins/lacp/lacp.c index dfe11b18ee8..7bd6e374dab 100644 --- a/src/plugins/lacp/lacp.c +++ b/src/plugins/lacp/lacp.c @@ -363,10 +363,10 @@ lacp_sw_interface_up_down (vnet_main_t * vnm, u32 sw_if_index, u32 flags) { if (sif->lacp_enabled) { - lacp_init_state_machines (vm, sif); lacp_init_neighbor (sif, sif->actor_admin.system, ntohs (sif->actor_admin.port_number), ntohs (sif->actor_admin.key)); + lacp_init_state_machines (vm, sif); } } } @@ -392,10 +392,10 @@ lacp_hw_interface_up_down (vnet_main_t * vnm, u32 hw_if_index, u32 flags) { if (sif->lacp_enabled) { - lacp_init_state_machines (vm, sif); lacp_init_neighbor (sif, sif->actor_admin.system, ntohs (sif->actor_admin.port_number), ntohs (sif->actor_admin.key)); + lacp_init_state_machines (vm, sif); } } } -- cgit 1.2.3-korg