From ff7d642f3db5302e1fe70b6f1b9afdb4c63fa1d8 Mon Sep 17 00:00:00 2001 From: Damjan Marion Date: Fri, 28 Oct 2016 23:52:40 +0200 Subject: vhost-user: fix crash in vhost_user_intfc_tx (VPP-519) The crash was the result of indexing off the end of the next[] array. Removing that prefetch code completelly, as it is questionable how much it helps so late in the game. Change-Id: I7bc83483a1088437edb4ac0f95a54c39afce136b Signed-off-by: Damjan Marion --- vnet/vnet/devices/virtio/vhost-user.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/vnet/vnet/devices/virtio/vhost-user.c b/vnet/vnet/devices/virtio/vhost-user.c index fd3cd21f859..5916ced2570 100644 --- a/vnet/vnet/devices/virtio/vhost-user.c +++ b/vnet/vnet/devices/virtio/vhost-user.c @@ -1634,12 +1634,6 @@ vhost_user_intfc_tx (vlib_main_t * vm, desc_len += bytes_to_copy; } - if (PREDICT_TRUE (n_left >= 2)) - { - vlib_prefetch_buffer_with_index (vm, buffers[1], STORE); - CLIB_PREFETCH (&n_left, sizeof (n_left), STORE); - } - //Move from available to used ring rxvq->used->ring[rxvq->last_used_idx & qsz_mask].id = desc_head; rxvq->used->ring[rxvq->last_used_idx & qsz_mask].len = desc_len; -- cgit 1.2.3-korg