From 6809538e646bf86c000dc1faba60b0a4157ad898 Mon Sep 17 00:00:00 2001 From: Mohsin Kazmi Date: Wed, 10 Feb 2021 11:26:24 +0100 Subject: vlib: refactor checksum offload support Type: refactor This patch refactors the offload flags in vlib_buffer_t. There are two main reasons behind this refactoring. First, offload flags are insufficient to represent outer and inner headers offloads. Second, room for these flags in first cacheline of vlib_buffer_t is also limited. This patch introduces a generic offload flag in first cacheline. And detailed offload flags in 2nd cacheline of the structure for performance optimization. Change-Id: Icc363a142fb9208ec7113ab5bbfc8230181f6004 Signed-off-by: Mohsin Kazmi --- src/plugins/gtpu/gtpu_decap.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) (limited to 'src/plugins/gtpu/gtpu_decap.c') diff --git a/src/plugins/gtpu/gtpu_decap.c b/src/plugins/gtpu/gtpu_decap.c index e3bc476ed6d..974ae8a8190 100644 --- a/src/plugins/gtpu/gtpu_decap.c +++ b/src/plugins/gtpu/gtpu_decap.c @@ -1257,13 +1257,15 @@ static char *gtpu_flow_error_strings[] = { }; -#define gtpu_local_need_csum_check(_b) \ - (!(_b->flags & VNET_BUFFER_F_L4_CHECKSUM_COMPUTED \ - || _b->flags & VNET_BUFFER_F_OFFLOAD_UDP_CKSUM)) - -#define gtpu_local_csum_is_valid(_b) \ - ((_b->flags & VNET_BUFFER_F_L4_CHECKSUM_CORRECT \ - || _b->flags & VNET_BUFFER_F_OFFLOAD_UDP_CKSUM) != 0) +#define gtpu_local_need_csum_check(_b) \ + (!(_b->flags & VNET_BUFFER_F_L4_CHECKSUM_COMPUTED || \ + (_b->flags & VNET_BUFFER_F_OFFLOAD && \ + vnet_buffer2 (_b)->oflags & VNET_BUFFER_OFFLOAD_F_UDP_CKSUM))) + +#define gtpu_local_csum_is_valid(_b) \ + ((_b->flags & VNET_BUFFER_F_L4_CHECKSUM_CORRECT || \ + (_b->flags & VNET_BUFFER_F_OFFLOAD && \ + vnet_buffer2 (_b)->oflags & VNET_BUFFER_OFFLOAD_F_UDP_CKSUM)) != 0) static_always_inline u8 gtpu_validate_udp_csum (vlib_main_t * vm, vlib_buffer_t *b) -- cgit 1.2.3-korg