From dd298e804a25dbebc9e284b3b2d0dfd9bf674ad8 Mon Sep 17 00:00:00 2001 From: Damjan Marion Date: Wed, 12 Oct 2022 16:02:18 +0200 Subject: misc: fix issues reported by clang-15 Type: improvement Change-Id: I3fbbda0378b72843ecd39a7e8592dedc9757793a Signed-off-by: Damjan Marion --- src/plugins/ikev2/ikev2.c | 9 +++++---- src/plugins/ikev2/ikev2_priv.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) (limited to 'src/plugins/ikev2') diff --git a/src/plugins/ikev2/ikev2.c b/src/plugins/ikev2/ikev2.c index 32331ffa6e4..f0eaa7a4355 100644 --- a/src/plugins/ikev2/ikev2.c +++ b/src/plugins/ikev2/ikev2.c @@ -4445,7 +4445,7 @@ ikev2_resolve_responder_hostname (vlib_main_t *vm, ikev2_responder_t *r) u8 *name; int rv; - if (!km->dns_resolve_name) + if (!km->dns_resolve_name_ptr) return clib_error_return (0, "cannot load symbols from dns plugin"); t0->request_type = DNS_API_PENDING_NAME_TO_IP; @@ -4453,7 +4453,8 @@ ikev2_resolve_responder_hostname (vlib_main_t *vm, ikev2_responder_t *r) * whereas DNS resolver expects a NULL-terminated C-string */ name = vec_dup (r->hostname); vec_terminate_c_string (name); - rv = km->dns_resolve_name (name, &ep, t0, rn); + rv = ((__typeof__ (dns_resolve_name) *) km->dns_resolve_name_ptr) (name, &ep, + t0, rn); vec_free (name); if (rv < 0) return clib_error_return (0, "dns lookup failure"); @@ -5443,9 +5444,9 @@ ikev2_lazy_init (ikev2_main_t *km) km->punt_hdl = vlib_punt_client_register ("ikev2"); - km->dns_resolve_name = + km->dns_resolve_name_ptr = vlib_get_plugin_symbol ("dns_plugin.so", "dns_resolve_name"); - if (!km->dns_resolve_name) + if (!km->dns_resolve_name_ptr) ikev2_log_error ("cannot load symbols from dns plugin"); /* wake up ikev2 process */ diff --git a/src/plugins/ikev2/ikev2_priv.h b/src/plugins/ikev2/ikev2_priv.h index 4ce147890d5..faa0ca75d66 100644 --- a/src/plugins/ikev2/ikev2_priv.h +++ b/src/plugins/ikev2/ikev2_priv.h @@ -532,7 +532,7 @@ typedef struct u8 dpd_disabled; /* pointer to name resolver function in dns plugin */ - int (*dns_resolve_name) (); + void *dns_resolve_name_ptr; /* flag indicating whether lazy init is done or not */ int lazy_init_done; -- cgit 1.2.3-korg