From 149a1433b0e6301a34989f5e8c7ebed3fa5bf74e Mon Sep 17 00:00:00 2001 From: Gabriel Ganne Date: Thu, 11 Jan 2018 15:09:38 +0100 Subject: fix udp_ping api naming error Error messages: ERROR:VAPI CPP GEN:Cannot find reply to message `udp_ping_add_del_req' ERROR:VAPI CPP GEN:Cannot find reply to message `udp_ping_export_req' ERROR:VAPI C GEN:Cannot find reply to message `udp_ping_add_del_req' ERROR:VAPI C GEN:Cannot find reply to message `udp_ping_export_req' Api was *_req/*_resp, but when explicitely declared, the reply should then have been *_req_reply. Both api response are empty, so I propose to remove them, and use autoreply API changes: rename udp_ping_add_del_req -> udp_ping_add_del rename udp_ping_export_req -> udp_ping_export delete udp_ping_add_del_reply (empty response) delete udp_ping_export_reply (empty response) vl_api_version 1.0.0 ->2.0.0 Change-Id: Id3456c8101a7689fbc56dc2d9076625c2b3af0ad Signed-off-by: Gabriel Ganne --- src/plugins/ioam/udp-ping/udp_ping.api | 24 +++--------------------- 1 file changed, 3 insertions(+), 21 deletions(-) (limited to 'src/plugins/ioam/udp-ping/udp_ping.api') diff --git a/src/plugins/ioam/udp-ping/udp_ping.api b/src/plugins/ioam/udp-ping/udp_ping.api index 6a5a6e68a03..b5b5f23810b 100644 --- a/src/plugins/ioam/udp-ping/udp_ping.api +++ b/src/plugins/ioam/udp-ping/udp_ping.api @@ -14,7 +14,7 @@ * limitations under the License. */ -vl_api_version 1.0.0 +vl_api_version 2.0.0 /** \brief UDP-Probe Add/Delete request @param src_ip_address - Source ipv4/v6 address for the udp-ping flow @@ -27,7 +27,7 @@ vl_api_version 1.0.0 @param is_ipv4 - To determine whether IPv4 or IPv6 address is used @param dis - TRUE is delete, FALSE if Add */ -define udp_ping_add_del_req { +autoreply define udp_ping_add_del { u32 client_index; u32 context; u8 src_ip_address[16]; @@ -43,32 +43,14 @@ define udp_ping_add_del_req { u8 reserve[3]; }; -/** \brief Udp-probe add/del response - @param context - sender context, to match reply w/ request - @param retval - return value for request -*/ -define udp_ping_add_del_reply { - u32 context; - i32 retval; -}; - /** \brief Udp-probe export add/del request @param context - sender context, to match reply w/ request @param retval - return value for request @param enable - If TRUE then enable export else disable */ -define udp_ping_export_req { +autoreply define udp_ping_export { u32 client_index; u32 context; u32 enable; }; -/** \brief Udp-probe export add/del response - @param context - sender context, to match reply w/ request - @param retval - return value for request -*/ -define udp_ping_export_reply { - u32 context; - i32 retval; -}; - -- cgit 1.2.3-korg