From 7071952df81122a601ff84cccb7e1a2539a49941 Mon Sep 17 00:00:00 2001 From: Ole Troan Date: Mon, 30 Sep 2019 13:11:35 +0200 Subject: mactime: remove api boilerplate Type: refactor Signed-off-by: Ole Troan Change-Id: I034cc6fb2a12d1b43b3470a1ba39cc1fe020386a --- src/plugins/mactime/mactime_test.c | 92 ++------------------------------------ 1 file changed, 3 insertions(+), 89 deletions(-) (limited to 'src/plugins/mactime/mactime_test.c') diff --git a/src/plugins/mactime/mactime_test.c b/src/plugins/mactime/mactime_test.c index c9c1a475ad9..8d87e788b7a 100644 --- a/src/plugins/mactime/mactime_test.c +++ b/src/plugins/mactime/mactime_test.c @@ -24,29 +24,8 @@ uword vat_unformat_sw_if_index (unformat_input_t * input, va_list * args); /* Declare message IDs */ -#include - -/* define message structures */ -#define vl_typedefs -#include -#undef vl_typedefs - -/* declare message handlers for each api */ - -#define vl_endianfun /* define message structures */ -#include -#undef vl_endianfun - -/* instantiate all the print functions we know about */ -#define vl_print(handle, ...) -#define vl_printfun -#include -#undef vl_printfun - -/* Get the API version number. */ -#define vl_api_version(n,v) static u32 api_version=(v); -#include -#undef vl_api_version +#include +#include typedef struct { @@ -60,34 +39,6 @@ mactime_test_main_t mactime_test_main; #define __plugin_msg_base mactime_test_main.msg_id_base #include -#define foreach_standard_reply_retval_handler \ -_(mactime_enable_disable_reply) \ -_(mactime_add_del_range_reply) - -#define _(n) \ - static void vl_api_##n##_t_handler \ - (vl_api_##n##_t * mp) \ - { \ - vat_main_t * vam = mactime_test_main.vat_main; \ - i32 retval = ntohl(mp->retval); \ - if (vam->async_mode) { \ - vam->async_errors += (retval < 0); \ - } else { \ - vam->retval = retval; \ - vam->result_ready = 1; \ - } \ - } -foreach_standard_reply_retval_handler; -#undef _ - -/* - * Table of message reply handlers, must include boilerplate handlers - * we just generated - */ -#define foreach_vpe_api_reply_msg \ -_(MACTIME_ENABLE_DISABLE_REPLY, mactime_enable_disable_reply) \ -_(MACTIME_ADD_DEL_RANGE_REPLY, mactime_add_del_range_reply) - static int api_mactime_enable_disable (vat_main_t * vam) { @@ -263,44 +214,7 @@ api_mactime_add_del_range (vat_main_t * vam) return ret; } -/* - * List of messages that the api test plugin sends, - * and that the data plane plugin processes - */ -#define foreach_vpe_api_msg \ -_(mactime_enable_disable, " [disable]") \ -_(mactime_add_del_range, \ - "name mac allow drop\n" \ - "allow-range Mon - Fri 9:00 - 17:00") - -static void -mactime_api_hookup (vat_main_t * vam) -{ - mactime_test_main_t *sm = &mactime_test_main; - /* Hook up handlers for replies from the data plane plug-in */ -#define _(N,n) \ - vl_msg_api_set_handlers((VL_API_##N + sm->msg_id_base), \ - #n, \ - vl_api_##n##_t_handler, \ - vl_noop_handler, \ - vl_api_##n##_t_endian, \ - vl_api_##n##_t_print, \ - sizeof(vl_api_##n##_t), 1); - foreach_vpe_api_reply_msg; -#undef _ - - /* API messages we can send */ -#define _(n,h) hash_set_mem (vam->function_by_name, #n, api_##n); - foreach_vpe_api_msg; -#undef _ - - /* Help strings */ -#define _(n,h) hash_set_mem (vam->help_by_name, #n, h); - foreach_vpe_api_msg; -#undef _ -} - -VAT_PLUGIN_REGISTER (mactime); +#include /* * fd.io coding-style-patch-verification: ON -- cgit 1.2.3-korg