From 958cff701dfb86f25407b14f7da5375a9503dfbe Mon Sep 17 00:00:00 2001 From: Ole Troan Date: Tue, 11 Sep 2018 11:26:12 +0200 Subject: VAT: plugin load errors - NSH plugin overrode vat_api_hookup() - Missing format function in mactime. Change-Id: I2dcbc2522d8f525d223c2ee3bb667111d1b3b78e Signed-off-by: Ole Troan --- src/plugins/mactime/mactime_test.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) (limited to 'src/plugins/mactime') diff --git a/src/plugins/mactime/mactime_test.c b/src/plugins/mactime/mactime_test.c index 309b101bad9..351493daf24 100644 --- a/src/plugins/mactime/mactime_test.c +++ b/src/plugins/mactime/mactime_test.c @@ -129,6 +129,23 @@ api_mactime_enable_disable (vat_main_t * vam) return ret; } +/* These two ought to be in a library somewhere but they aren't */ +static uword +my_unformat_mac_address (unformat_input_t * input, va_list * args) +{ + u8 *a = va_arg (*args, u8 *); + return unformat (input, "%x:%x:%x:%x:%x:%x", &a[0], &a[1], &a[2], &a[3], + &a[4], &a[5]); +} + +static u8 * +my_format_mac_address (u8 * s, va_list * args) +{ + u8 *a = va_arg (*args, u8 *); + return format (s, "%02x:%02x:%02x:%02x:%02x:%02x", + a[0], a[1], a[2], a[3], a[4], a[5]); +} + static int api_mactime_add_del_range (vat_main_t * vam) { @@ -163,7 +180,7 @@ api_mactime_add_del_range (vat_main_t * vam) allow = 1; else if (unformat (i, "drop-static")) drop = 1; - else if (unformat (i, "mac %U", unformat_mac_address, mac_address)) + else if (unformat (i, "mac %U", my_unformat_mac_address, mac_address)) mac_set = 1; else if (unformat (i, "del")) is_add = 0; @@ -200,7 +217,7 @@ api_mactime_add_del_range (vat_main_t * vam) /* Cough up a device name if none set */ if (name_set == 0) { - device_name = format (0, "mac %U%c", format_mac_address, + device_name = format (0, "mac %U%c", my_format_mac_address, mac_address, 0); } -- cgit 1.2.3-korg