From 4496243cc9c9f5a64483923e1f158cab74aca18a Mon Sep 17 00:00:00 2001 From: Filip Varga Date: Wed, 3 Jun 2020 15:26:41 +0200 Subject: nat: fixed input validation Ticket: VPP-1887 Type: fix Change-Id: I341ac7b455926a106d736f4de6771aae655db82e Signed-off-by: Filip Varga --- src/plugins/nat/nat_inlines.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/plugins/nat/nat_inlines.h') diff --git a/src/plugins/nat/nat_inlines.h b/src/plugins/nat/nat_inlines.h index 4dad11bed72..7c28919f781 100644 --- a/src/plugins/nat/nat_inlines.h +++ b/src/plugins/nat/nat_inlines.h @@ -545,7 +545,7 @@ get_icmp_i2o_ed_key (vlib_buffer_t * b, ip4_header_t * ip0, u32 rx_fib_index, proto = IP_PROTOCOL_ICMP; l_addr = &ip0->src_address; r_addr = &ip0->dst_address; - _l_port = vnet_buffer (b)->ip.reass.l4_src_port; // TODO should this be src or dst? + _l_port = vnet_buffer (b)->ip.reass.l4_src_port; _r_port = 0; } else @@ -613,7 +613,7 @@ get_icmp_o2i_ed_key (vlib_buffer_t * b, ip4_header_t * ip0, u32 rx_fib_index, proto = IP_PROTOCOL_ICMP; l_addr = &ip0->dst_address; r_addr = &ip0->src_address; - _l_port = vnet_buffer (b)->ip.reass.l4_src_port; // TODO should this be src or dst? + _l_port = vnet_buffer (b)->ip.reass.l4_src_port; _r_port = 0; } else -- cgit 1.2.3-korg